Merge branch 'remove-ff-ci_pipeline_schedule_async' into 'master'

Remove FF ci_pipeline_schedule_async

See merge request gitlab-org/gitlab!30594

app/services/ci/pipeline_schedule_service.rb

@@ -6,19 +6,7 @@ module Ci
       # Ensure `next_run_at` is set properly before creating a pipeline.
       # Otherwise, multiple pipelines could be created in a short interval.
       schedule.schedule_next_run!
-
-      if Feature.enabled?(:ci_pipeline_schedule_async)
-        RunPipelineScheduleWorker.perform_async(schedule.id, schedule.owner&.id)
-      else
-        begin
-          RunPipelineScheduleWorker.new.perform(schedule.id, schedule.owner&.id)
-        ensure
-          ##
-          # This is the temporary solution for avoiding the memory bloat.
-          # See more https://gitlab.com/gitlab-org/gitlab-foss/issues/61955
-          GC.start if Feature.enabled?(:ci_pipeline_schedule_force_gc, default_enabled: true)
-        end
-      end
+      RunPipelineScheduleWorker.perform_async(schedule.id, schedule.owner&.id)
     end
   end
 end

spec/services/ci/pipeline_schedule_service_spec.rb

@@ -25,38 +25,6 @@ describe Ci::PipelineScheduleService do
       subject
     end
 
-    context 'when ci_pipeline_schedule_async feature flag is disabled' do
-      before do
-        stub_feature_flags(ci_pipeline_schedule_async: false)
-      end
-
-      it 'runs RunPipelineScheduleWorker synchronously' do
-        expect_next_instance_of(RunPipelineScheduleWorker) do |worker|
-          expect(worker).to receive(:perform).with(schedule.id, schedule.owner.id)
-        end
-
-        subject
-      end
-
-      it 'calls Garbage Collection manually' do
-        expect(GC).to receive(:start)
-
-        subject
-      end
-
-      context 'when ci_pipeline_schedule_force_gc feature flag is disabled' do
-        before do
-          stub_feature_flags(ci_pipeline_schedule_force_gc: false)
-        end
-
-        it 'does not call Garbage Collection manually' do
-          expect(GC).not_to receive(:start)
-
-          subject
-        end
-      end
-    end
-
     context 'when owner is nil' do
       let(:schedule) { create(:ci_pipeline_schedule, project: project, owner: nil) }