Merge branch 'fj-change-routable-redirect-to-301' into 'master'

Change permanent routable redirect to 301

See merge request gitlab-org/gitlab!45980

app/controllers/concerns/routable_actions.rb

@@ -51,7 +51,7 @@ module RoutableActions
         flash[:notice] = "#{routable.class.to_s.titleize} '#{requested_full_path}' was moved to '#{canonical_path}'. Please update any links and bookmarks that may still have the old path."
       end
 
-      redirect_to build_canonical_path(routable)
+      redirect_to build_canonical_path(routable), status: :moved_permanently
     end
   end
 end

changelogs/unreleased/fj-change-routable-redirect-to-301.yml

+---
+title: Change permanent routable redirect to 301
+merge_request: 45980
+author:
+type: changed

ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb

@@ -49,7 +49,7 @@ RSpec.describe Projects::Integrations::Jira::IssuesController do
         get :index, params: { namespace_id: project.namespace, project_id: project }
 
         expect(response).to redirect_to(project_integrations_jira_issues_path(new_project))
-        expect(response).to have_gitlab_http_status(:found)
+        expect(response).to have_gitlab_http_status(:moved_permanently)
       end
     end
 

spec/controllers/projects/issues_controller_spec.rb

@@ -52,14 +52,14 @@ RSpec.describe Projects::IssuesController do
           get :index, params: { namespace_id: project.namespace, project_id: project }
 
           expect(response).to redirect_to(project_issues_path(new_project))
-          expect(response).to have_gitlab_http_status(:found)
+          expect(response).to have_gitlab_http_status(:moved_permanently)
         end
 
         it 'redirects from an old issue correctly' do
           get :show, params: { namespace_id: project.namespace, project_id: project, id: issue }
 
           expect(response).to redirect_to(project_issue_path(new_project, issue))
-          expect(response).to have_gitlab_http_status(:found)
+          expect(response).to have_gitlab_http_status(:moved_permanently)
         end
       end
     end
@@ -1869,7 +1869,7 @@ RSpec.describe Projects::IssuesController do
             }
 
         expect(response).to redirect_to(designs_project_issue_path(new_project, issue))
-        expect(response).to have_gitlab_http_status(:found)
+        expect(response).to have_gitlab_http_status(:moved_permanently)
       end
     end
   end

spec/controllers/projects/merge_requests_controller_spec.rb

@@ -161,7 +161,7 @@ RSpec.describe Projects::MergeRequestsController do
               }
 
           expect(response).to redirect_to(project_merge_request_path(new_project, merge_request))
-          expect(response).to have_gitlab_http_status(:found)
+          expect(response).to have_gitlab_http_status(:moved_permanently)
         end
 
         it 'redirects from an old merge request commits correctly' do
@@ -173,7 +173,7 @@ RSpec.describe Projects::MergeRequestsController do
               }
 
           expect(response).to redirect_to(commits_project_merge_request_path(new_project, merge_request))
-          expect(response).to have_gitlab_http_status(:found)
+          expect(response).to have_gitlab_http_status(:moved_permanently)
         end
       end
     end