Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e68cd16e
Commit
e68cd16e
authored
Nov 13, 2020
by
Erick Bajao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove track_unique_test_cases_parsed feature flag
parent
03cb239c
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
22 deletions
+5
-22
app/services/ci/build_report_result_service.rb
app/services/ci/build_report_result_service.rb
+0
-2
changelogs/unreleased/eb-remove-tracking-test-cases-feature-flag.yml
...unreleased/eb-remove-tracking-test-cases-feature-flag.yml
+5
-0
config/feature_flags/development/track_unique_test_cases_parsed.yml
...ture_flags/development/track_unique_test_cases_parsed.yml
+0
-8
spec/services/ci/build_report_result_service_spec.rb
spec/services/ci/build_report_result_service_spec.rb
+0
-12
No files found.
app/services/ci/build_report_result_service.rb
View file @
e68cd16e
...
@@ -39,8 +39,6 @@ module Ci
...
@@ -39,8 +39,6 @@ module Ci
end
end
def
track_test_cases
(
build
,
test_suite
)
def
track_test_cases
(
build
,
test_suite
)
return
if
Feature
.
disabled?
(
:track_unique_test_cases_parsed
,
build
.
project
)
track_usage_event
(
EVENT_NAME
,
test_case_hashes
(
build
,
test_suite
))
track_usage_event
(
EVENT_NAME
,
test_case_hashes
(
build
,
test_suite
))
end
end
...
...
changelogs/unreleased/eb-remove-tracking-test-cases-feature-flag.yml
0 → 100644
View file @
e68cd16e
---
title
:
Remove feature flag to enable tracking unique test cases parsed globally.
merge_request
:
47662
author
:
type
:
changed
config/feature_flags/development/track_unique_test_cases_parsed.yml
deleted
100644 → 0
View file @
03cb239c
---
name
:
track_unique_test_cases_parsed
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41918
rollout_issue_url
:
milestone
:
'
13.5'
type
:
development
group
:
group::testing
default_enabled
:
false
spec/services/ci/build_report_result_service_spec.rb
View file @
e68cd16e
...
@@ -26,18 +26,6 @@ RSpec.describe Ci::BuildReportResultService do
...
@@ -26,18 +26,6 @@ RSpec.describe Ci::BuildReportResultService do
expect
(
unique_test_cases_parsed
).
to
eq
(
4
)
expect
(
unique_test_cases_parsed
).
to
eq
(
4
)
end
end
context
'when feature flag for tracking is disabled'
do
before
do
stub_feature_flags
(
track_unique_test_cases_parsed:
false
)
end
it
'creates the report but does not track the event'
do
expect
(
Gitlab
::
UsageDataCounters
::
HLLRedisCounter
).
not_to
receive
(
:track_event
)
expect
(
build_report_result
.
tests_name
).
to
eq
(
"test"
)
expect
(
Ci
::
BuildReportResult
.
count
).
to
eq
(
1
)
end
end
context
'when data has already been persisted'
do
context
'when data has already been persisted'
do
it
'raises an error and do not persist the same data twice'
do
it
'raises an error and do not persist the same data twice'
do
expect
{
2
.
times
{
described_class
.
new
.
execute
(
build
)
}
}.
to
raise_error
(
ActiveRecord
::
RecordNotUnique
)
expect
{
2
.
times
{
described_class
.
new
.
execute
(
build
)
}
}.
to
raise_error
(
ActiveRecord
::
RecordNotUnique
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment