Remove feature flag multiple_gpg_signatures

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/345261

Changelog: other

config/feature_flags/development/multiple_gpg_signatures.yml

----
-name: multiple_gpg_signatures
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/74095
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/345261
-milestone: '14.5'
-type: development
-group: group::source code
-default_enabled: true

lib/gitlab/gpg/commit.rb

@@ -102,7 +102,7 @@ module Gitlab
       end
 
       def verification_status(gpg_key)
-        return :multiple_signatures if multiple_signatures? && Feature.enabled?(:multiple_gpg_signatures, @commit.project, default_enabled: :yaml)
+        return :multiple_signatures if multiple_signatures?
         return :unknown_key unless gpg_key
         return :unverified_key unless gpg_key.verified?
         return :unverified unless verified_signature&.valid?

spec/lib/gitlab/gpg/commit_spec.rb

@@ -233,30 +233,6 @@ RSpec.describe Gitlab::Gpg::Commit do
               verification_status: 'multiple_signatures'
             )
           end
-
-          context 'when feature flag is disabled' do
-            before do
-              stub_feature_flags(multiple_gpg_signatures: false)
-            end
-
-            it 'returns an valid signature' do
-              verified_signature = double('verified-signature', fingerprint: GpgHelpers::User1.fingerprint, valid?: true)
-              allow(GPGME::Crypto).to receive(:new).and_return(crypto)
-              allow(crypto).to receive(:verify).and_yield(verified_signature).and_yield(verified_signature)
-
-              signature = described_class.new(commit).signature
-
-              expect(signature).to have_attributes(
-                commit_sha: commit_sha,
-                project: project,
-                gpg_key: gpg_key,
-                gpg_key_primary_keyid: GpgHelpers::User1.primary_keyid,
-                gpg_key_user_name: GpgHelpers::User1.names.first,
-                gpg_key_user_email: GpgHelpers::User1.emails.first,
-                verification_status: 'verified'
-              )
-            end
-          end
         end
 
         context 'commit signed with a subkey' do