Commit e7498166 authored by Micael Bergeron's avatar Micael Bergeron

Update the N+1 thresholds in the spec

parent 9eb5ebf9
...@@ -80,8 +80,7 @@ RSpec.describe API::Search do ...@@ -80,8 +80,7 @@ RSpec.describe API::Search do
ensure_elasticsearch_index! ensure_elasticsearch_index!
# Some N+1 queries still exist expect { get api(endpoint, user), params: { scope: 'merge_requests', search: '*' } }.not_to exceed_query_limit(control)
expect { get api(endpoint, user), params: { scope: 'merge_requests', search: '*' } }.not_to exceed_query_limit(control.count + 16)
end end
end end
...@@ -125,7 +124,7 @@ RSpec.describe API::Search do ...@@ -125,7 +124,7 @@ RSpec.describe API::Search do
ensure_elasticsearch_index! ensure_elasticsearch_index!
# Some N+1 queries still exist # Some N+1 queries still exist
expect { get api(endpoint, user), params: { scope: 'commits', search: 'folder' } }.not_to exceed_query_limit(control.count + 9) expect { get api(endpoint, user), params: { scope: 'commits', search: 'folder' } }.not_to exceed_query_limit(control).with_threshold(9)
end end
end end
...@@ -187,8 +186,7 @@ RSpec.describe API::Search do ...@@ -187,8 +186,7 @@ RSpec.describe API::Search do
ensure_elasticsearch_index! ensure_elasticsearch_index!
# Some N+1 queries still exist expect { get api(endpoint, user), params: { scope: 'issues', search: '*' } }.not_to exceed_query_limit(control)
expect { get api(endpoint, user), params: { scope: 'issues', search: '*' } }.not_to exceed_query_limit(control.count + 2)
end end
it_behaves_like 'pagination', scope: 'issues' it_behaves_like 'pagination', scope: 'issues'
...@@ -213,7 +211,7 @@ RSpec.describe API::Search do ...@@ -213,7 +211,7 @@ RSpec.describe API::Search do
ensure_elasticsearch_index! ensure_elasticsearch_index!
# Some N+1 queries still exist # Some N+1 queries still exist
expect { get api(endpoint, user), params: { scope: 'projects', search: '*' } }.not_to exceed_query_limit(control.count + 4) expect { get api(endpoint, user), params: { scope: 'projects', search: '*' } }.not_to exceed_query_limit(control).with_threshold(4)
end end
end end
end end
...@@ -234,7 +232,7 @@ RSpec.describe API::Search do ...@@ -234,7 +232,7 @@ RSpec.describe API::Search do
ensure_elasticsearch_index! ensure_elasticsearch_index!
expect { get api(endpoint, user), params: { scope: 'milestones', search: '*' } }.not_to exceed_query_limit(control.count) expect { get api(endpoint, user), params: { scope: 'milestones', search: '*' } }.not_to exceed_query_limit(control)
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment