Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e77f4dff
Commit
e77f4dff
authored
Feb 03, 2021
by
Sarah Groff Hennigh-Palermo
Committed by
Natalia Tepluhina
Feb 03, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pipeline Graph Structural Update: SVG Bugfix
parent
c89d94e5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
2 deletions
+10
-2
app/assets/javascripts/pipelines/components/graph/graph_component.vue
...avascripts/pipelines/components/graph/graph_component.vue
+3
-2
app/assets/javascripts/pipelines/components/graph/stage_column_component.vue
...pts/pipelines/components/graph/stage_column_component.vue
+3
-0
spec/frontend/pipelines/graph/stage_column_component_spec.js
spec/frontend/pipelines/graph/stage_column_component_spec.js
+4
-0
No files found.
app/assets/javascripts/pipelines/components/graph/graph_component.vue
View file @
e77f4dff
...
...
@@ -86,11 +86,11 @@ export default {
reportToSentry
(
this
.
$options
.
name
,
`error:
${
err
}
, info:
${
info
}
`
);
},
mounted
()
{
this
.
measurements
=
this
.
getMeasurements
();
this
.
getMeasurements
();
},
methods
:
{
getMeasurements
()
{
return
{
this
.
measurements
=
{
width
:
this
.
$refs
[
this
.
containerId
].
scrollWidth
,
height
:
this
.
$refs
[
this
.
containerId
].
scrollHeight
,
};
...
...
@@ -161,6 +161,7 @@ export default {
:pipeline-id=
"pipeline.id"
@
refreshPipelineGraph=
"$emit('refreshPipelineGraph')"
@
jobHover=
"setJob"
@
updateMeasurements=
"getMeasurements"
/>
</links-layer>
</div>
...
...
app/assets/javascripts/pipelines/components/graph/stage_column_component.vue
View file @
e77f4dff
...
...
@@ -67,6 +67,9 @@ export default {
errorCaptured
(
err
,
_vm
,
info
)
{
reportToSentry
(
'
stage_column_component
'
,
`error:
${
err
}
, info:
${
info
}
`
);
},
mounted
()
{
this
.
$emit
(
'
updateMeasurements
'
);
},
methods
:
{
getGroupId
(
group
)
{
return
accessValue
(
GRAPHQL
,
'
groupId
'
,
group
);
...
...
spec/frontend/pipelines/graph/stage_column_component_spec.js
View file @
e77f4dff
...
...
@@ -68,6 +68,10 @@ describe('stage column component', () => {
it
(
'
should render the provided groups
'
,
()
=>
{
expect
(
findAllStageColumnGroups
().
length
).
toBe
(
mockGroups
.
length
);
});
it
(
'
should emit updateMeasurements event on mount
'
,
()
=>
{
expect
(
wrapper
.
emitted
().
updateMeasurements
).
toHaveLength
(
1
);
});
});
describe
(
'
when job notifies action is complete
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment