Merge branch '202273-migrate-spinner-for-app/assets/javascripts/gpg_badges.js' into 'master'

Migrate '.fa-spinner' to '.spinner' for 'app/.../gpg_badges.js'

Closes #202273

See merge request gitlab-org/gitlab!41136

app/assets/javascripts/gpg_badges.js

@@ -13,7 +13,8 @@ export default class GpgBadges {
 
     const badges = $('.js-loading-gpg-badge');
 
-    badges.html('<i class="fa fa-spinner fa-spin"></i>');
+    badges.html('<span class="gl-spinner gl-spinner-orange gl-spinner-sm"></span>');
+    badges.children().attr('aria-label', __('Loading'));
 
     const displayError = () => createFlash(__('An error occurred while loading commit signatures'));
 

changelogs/unreleased/202273-migrate-spinner-for-app-assets-javascripts-gpg_badges-js.yml

+---
+title: Migrate '.fa-spinner' to '.spinner' for 'app/assets/javascripts/gpg_badges.js'
+merge_request: 41136
+author: Gilang Gumilar
+type: changed

spec/frontend/gpg_badges_spec.js

@@ -68,7 +68,7 @@ describe('GpgBadges', () => {
     GpgBadges.fetch()
       .then(() => {
         expect(document.querySelector('.js-loading-gpg-badge:empty')).toBe(null);
-        const spinners = document.querySelectorAll('.js-loading-gpg-badge i.fa.fa-spinner.fa-spin');
+        const spinners = document.querySelectorAll('.js-loading-gpg-badge span.gl-spinner');
 
         expect(spinners.length).toBe(1);
         done();