Commit e8dfbc64 authored by Mark Lapierre's avatar Mark Lapierre

Merge branch 'egb-skip-loading-check-base-page' into 'master'

Test framework update: allow tests to click elements without waiting for page to fully load

See merge request gitlab-org/gitlab!64166
parents 449671f2 dfc5abb6
......@@ -104,7 +104,8 @@ module QA
end
def find_element(name, **kwargs)
wait_for_requests
skip_finished_loading_check = kwargs.delete(:skip_finished_loading_check)
wait_for_requests(skip_finished_loading_check: skip_finished_loading_check)
element_selector = element_selector_css(name, reject_capybara_query_keywords(kwargs))
find(element_selector, only_capybara_query_keywords(kwargs))
......@@ -196,7 +197,8 @@ module QA
# replace with (..., page = self.class)
def click_element(name, page = nil, **kwargs)
wait_for_requests
skip_finished_loading_check = kwargs.delete(:skip_finished_loading_check)
wait_for_requests(skip_finished_loading_check: skip_finished_loading_check)
wait = kwargs.delete(:wait) || Capybara.default_max_wait_time
text = kwargs.delete(:text)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment