Commit e92f067e authored by Mark Florian's avatar Mark Florian Committed by Brandon Labuschagne

Remove vue/order-in-components override

The rule override was in place to make the transition to the latest
`vue/recommended` ruleset easier, i.e., tackled iteratively.

Now that most violations of this rule have been fixed, this override can
be removed, so that we adopt the stricter version from
`vue/recommended`.

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/297216.
parent 01eafdbc
...@@ -50,50 +50,6 @@ rules: ...@@ -50,50 +50,6 @@ rules:
# various vue lint rules as they were in eslint-plugin-vue@6, or disabling # various vue lint rules as they were in eslint-plugin-vue@6, or disabling
# new ones, to ease migration to v7, so violations of each can be fixed # new ones, to ease migration to v7, so violations of each can be fixed
# separately. # separately.
vue/order-in-components:
- error
# This is the order from eslint-plugin-vue@6.2.2
- order:
- el
- name
- parent
- functional
-
- delimiters
- comments
-
- components
- directives
- filters
- extends
- mixins
- inheritAttrs
- model
-
- props
- propsData
- fetch
- asyncData
- data
- computed
- watch
-
- beforeCreate
- created
- beforeMount
- mounted
- beforeUpdate
- updated
- activated
- deactivated
- beforeDestroy
- destroyed
- methods
- head
-
- template
- render
- renderError
vue/no-mutating-props: off vue/no-mutating-props: off
vue/one-component-per-file: off vue/one-component-per-file: off
vue/no-lone-template: off vue/no-lone-template: off
......
...@@ -33,13 +33,13 @@ export default { ...@@ -33,13 +33,13 @@ export default {
GlDropdownText, GlDropdownText,
GlSearchBoxByType, GlSearchBoxByType,
}, },
inject: ['groupId'],
props: { props: {
list: { list: {
type: Object, type: Object,
required: true, required: true,
}, },
}, },
inject: ['groupId'],
data() { data() {
return { return {
initialLoading: true, initialLoading: true,
......
...@@ -16,6 +16,7 @@ export default { ...@@ -16,6 +16,7 @@ export default {
MetricsImage, MetricsImage,
UploadDropzone, UploadDropzone,
}, },
inject: ['canUpdate', 'projectId', 'iid'],
data() { data() {
return { return {
currentFiles: [], currentFiles: [],
...@@ -23,7 +24,6 @@ export default { ...@@ -23,7 +24,6 @@ export default {
modalUrl: '', modalUrl: '',
}; };
}, },
inject: ['canUpdate', 'projectId', 'iid'],
store: createStore(), store: createStore(),
computed: { computed: {
...mapState(['metricImages', 'isLoadingMetricImages', 'isUploadingImage']), ...mapState(['metricImages', 'isLoadingMetricImages', 'isUploadingImage']),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment