Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e9d57390
Commit
e9d57390
authored
Oct 15, 2020
by
Dmytro Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use scoped profile routes by default
parent
1f42bb69
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
10 deletions
+3
-10
config/routes.rb
config/routes.rb
+1
-8
ee/spec/serializers/dashboard_operations_project_entity_spec.rb
...c/serializers/dashboard_operations_project_entity_spec.rb
+1
-1
spec/features/profiles/account_spec.rb
spec/features/profiles/account_spec.rb
+1
-1
No files found.
config/routes.rb
View file @
e9d57390
...
@@ -180,6 +180,7 @@ Rails.application.routes.draw do
...
@@ -180,6 +180,7 @@ Rails.application.routes.draw do
get
'jwks'
=>
'doorkeeper/openid_connect/discovery#keys'
get
'jwks'
=>
'doorkeeper/openid_connect/discovery#keys'
draw
:snippets
draw
:snippets
draw
:profile
# Product analytics collector
# Product analytics collector
match
'/collector/i'
,
to:
ProductAnalytics
::
CollectorApp
.
new
,
via: :all
match
'/collector/i'
,
to:
ProductAnalytics
::
CollectorApp
.
new
,
via: :all
...
@@ -266,7 +267,6 @@ Rails.application.routes.draw do
...
@@ -266,7 +267,6 @@ Rails.application.routes.draw do
draw
:uploads
draw
:uploads
draw
:explore
draw
:explore
draw
:admin
draw
:admin
draw
:profile
draw
:dashboard
draw
:dashboard
draw
:user
draw
:user
draw
:project
draw
:project
...
@@ -274,13 +274,6 @@ Rails.application.routes.draw do
...
@@ -274,13 +274,6 @@ Rails.application.routes.draw do
# Issue https://gitlab.com/gitlab-org/gitlab/-/issues/210024
# Issue https://gitlab.com/gitlab-org/gitlab/-/issues/210024
scope
as:
'deprecated'
do
scope
as:
'deprecated'
do
draw
:snippets
draw
:snippets
end
# Serve profile routes under /-/ scope.
# To ensure an old unscoped routing is used for the UI we need to
# add prefix 'as' to the scope routing and place it below original routing.
# Issue https://gitlab.com/gitlab-org/gitlab/-/issues/210024
scope
'-'
,
as: :scoped
do
draw
:profile
draw
:profile
end
end
...
...
ee/spec/serializers/dashboard_operations_project_entity_spec.rb
View file @
e9d57390
...
@@ -99,7 +99,7 @@ RSpec.describe DashboardOperationsProjectEntity do
...
@@ -99,7 +99,7 @@ RSpec.describe DashboardOperationsProjectEntity do
let
(
:user
)
{
build
(
:user
,
:admin
)
}
let
(
:user
)
{
build
(
:user
,
:admin
)
}
it
'shows the profile upgrade path'
do
it
'shows the profile upgrade path'
do
expect
(
subject
[
:upgrade_path
]).
to
eq
'/profile/billings'
expect
(
subject
[
:upgrade_path
]).
to
eq
'/
-/
profile/billings'
end
end
end
end
...
...
spec/features/profiles/account_spec.rb
View file @
e9d57390
...
@@ -33,7 +33,7 @@ RSpec.describe 'Profile > Account', :js do
...
@@ -33,7 +33,7 @@ RSpec.describe 'Profile > Account', :js do
end
end
it
'allows the user to disconnect when there is an existing identity'
do
it
'allows the user to disconnect when there is an existing identity'
do
expect
(
page
).
to
have_link
(
'Disconnect Twitter'
,
href:
'/profile/account/unlink?provider=twitter'
)
expect
(
page
).
to
have_link
(
'Disconnect Twitter'
,
href:
'/
-/
profile/account/unlink?provider=twitter'
)
end
end
it
'shows active for a provider that is not allowed to unlink'
do
it
'shows active for a provider that is not allowed to unlink'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment