Revert LegacyWriter open&initialize in constructor

ebd8fabb · nmilojevic1 · 6b0f9805 · ebd8fabb
Commit ebd8fabb authored Mar 11, 2020 by nmilojevic1
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

lib/gitlab/import_export/json/legacy_writer.rb lib/gitlab/import_export/json/legacy_writer.rb +2 -5

No files found.
--- a/lib/gitlab/import_export/json/legacy_writer.rb
+++ b/lib/gitlab/import_export/json/legacy_writer.rb
@@ -14,6 +14,7 @@ module Gitlab
          @keys = Set.new
          mkdir_p(File.dirname(@path))
+          file.write('{}')
        end
        def close
@@ -64,11 +65,7 @@ module Gitlab
        private
        def file
-          @file ||= begin
+          @file ||= File.open(@path, "wb")
-            file = File.open(@path, "wb")
-            file.write('{}')
-            file
-          end
        end
      end
    end