Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ed4a858e
Commit
ed4a858e
authored
Dec 28, 2019
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix docs-lint on doc/development/code_review.md
parent
ae1241e2
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
doc/development/code_review.md
doc/development/code_review.md
+2
-2
No files found.
doc/development/code_review.md
View file @
ed4a858e
...
@@ -267,12 +267,12 @@ context is fresh in memory, and improves contributors' experience significantly.
...
@@ -267,12 +267,12 @@ context is fresh in memory, and improves contributors' experience significantly.
To ensure swift feedback to ready-to-review code, we maintain a
`Review-response`
Service-level Objective (SLO). The SLO is defined as:
To ensure swift feedback to ready-to-review code, we maintain a
`Review-response`
Service-level Objective (SLO). The SLO is defined as:
>
*
review-response SLO = (time when first review response is provided) - (time MR is assigned to reviewer) < 2 business days
>
-
review-response SLO = (time when first review response is provided) - (time MR is assigned to reviewer) < 2 business days
If you don't think you'll be able to review a merge request within the
`Review-response`
SLO
If you don't think you'll be able to review a merge request within the
`Review-response`
SLO
time frame, let the author know as soon as possible and try to help them find
time frame, let the author know as soon as possible and try to help them find
another reviewer or maintainer who will be able to, so that they can be unblocked
another reviewer or maintainer who will be able to, so that they can be unblocked
and get on with their work quickly.
and get on with their work quickly.
Of course, if you are out of office and have
Of course, if you are out of office and have
[
communicated
](
https://about.gitlab.com/handbook/paid-time-off/#communicating-your-time-off
)
[
communicated
](
https://about.gitlab.com/handbook/paid-time-off/#communicating-your-time-off
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment