Replace fa-trash icons with GitLab SVG remove icon

`legacy_package_list` doesn't seem to be used but
I have replaced the icon so it can me removed
completely.

app/assets/stylesheets/fontawesome_custom.scss

@@ -130,10 +130,6 @@
   content: '\f101';
 }
 
-.fa-trash::before {
-  content: '\f1f8';
-}
-
 .fa-angle-double-left::before {
   content: '\f100';
 }

app/views/doorkeeper/applications/_delete_form.html.haml

@@ -5,6 +5,6 @@
     = button_tag type: "submit", class: "btn btn-transparent", data: { confirm: _("Are you sure?") } do
       %span.sr-only
         = _('Destroy')
-      = icon('trash')
+      = sprite_icon('remove')
   - else
     = submit_tag _('Destroy'), data: { confirm: _("Are you sure?") }, class: submit_btn_css

app/views/projects/packages/packages/_legacy_package_list.html.haml

@@ -52,7 +52,7 @@
             - if can_destroy_package
               .float-right
                 = link_to project_package_path(@project, package), method: :delete, data: { confirm: _("Are you sure?") }, class: "btn btn-grouped btn-remove", title: _('Delete Package') do
-                  = icon('trash')
+                  = sprite_icon('remove')
     = paginate @packages, theme: "gitlab"
 - else
   .row.empty-state

app/views/projects/triggers/_trigger.html.haml

@@ -34,4 +34,4 @@
         = sprite_icon('pencil')
     - if can?(current_user, :manage_trigger, trigger)
       = link_to project_trigger_path(@project, trigger), data: { confirm: revoke_trigger_confirmation }, method: :delete, title: "Revoke", class: "btn btn-default btn-warning btn-sm btn-trigger-revoke" do
-        %i.fa.fa-trash
+        = sprite_icon('remove')

changelogs/unreleased/225926-replace-fa-tag-s-icons-with-gitlab-svg-icons.yml

+---
+title: Replace fa-trash icons with GitLab SVG remove icon
+merge_request: 40579
+author:
+type: changed