Commit edf18105 authored by Mark Lapierre's avatar Mark Lapierre

Remove unnecessary debug status checks

Runtime::Logger defaults to reporting error messages, so we don't need
to check if QA_DEBUG is true when creating debug log messages (or any
other message severity below error). If QA_DEBUG is false the debug
messages won't be logged.
parent 94486f71
...@@ -64,7 +64,7 @@ module QA ...@@ -64,7 +64,7 @@ module QA
end end
def visit! def visit!
Runtime::Logger.debug(%Q[Visiting #{self.class.name} at "#{web_url}"]) if Runtime::Env.debug? Runtime::Logger.debug(%Q[Visiting #{self.class.name} at "#{web_url}"])
Support::Retrier.retry_until do Support::Retrier.retry_until do
visit(web_url) visit(web_url)
......
...@@ -79,7 +79,7 @@ module QA ...@@ -79,7 +79,7 @@ module QA
def api_delete def api_delete
super super
QA::Runtime::Logger.debug("Deleted user '#{username}'") if Runtime::Env.debug? QA::Runtime::Logger.debug("Deleted user '#{username}'")
end end
def api_delete_path def api_delete_path
......
...@@ -24,7 +24,7 @@ module QA ...@@ -24,7 +24,7 @@ module QA
# Wait for Action Mailer to deliver messages # Wait for Action Mailer to deliver messages
mailhog_json = Support::Retrier.retry_until(sleep_interval: 1) do mailhog_json = Support::Retrier.retry_until(sleep_interval: 1) do
Runtime::Logger.debug(%Q[retrieving "#{QA::Runtime::MailHog.api_messages_url}"]) if Runtime::Env.debug? Runtime::Logger.debug(%Q[retrieving "#{QA::Runtime::MailHog.api_messages_url}"])
mailhog_response = get QA::Runtime::MailHog.api_messages_url mailhog_response = get QA::Runtime::MailHog.api_messages_url
......
...@@ -330,7 +330,7 @@ module QA ...@@ -330,7 +330,7 @@ module QA
end end
def reset_idp_session def reset_idp_session
Runtime::Logger.debug(%Q[Visiting IDP url at "#{EE::Runtime::Saml.idp_sso_url}"]) if Runtime::Env.debug? Runtime::Logger.debug(%Q[Visiting IDP url at "#{EE::Runtime::Saml.idp_sso_url}"])
page.visit EE::Runtime::Saml.idp_sso_url page.visit EE::Runtime::Saml.idp_sso_url
Support::Waiter.wait { current_url == EE::Runtime::Saml.idp_sso_url } Support::Waiter.wait { current_url == EE::Runtime::Saml.idp_sso_url }
...@@ -339,7 +339,7 @@ module QA ...@@ -339,7 +339,7 @@ module QA
end end
def visit_managed_group_url def visit_managed_group_url
Runtime::Logger.debug(%Q[Visiting managed_group_url at "#{@managed_group_url}"]) if Runtime::Env.debug? Runtime::Logger.debug(%Q[Visiting managed_group_url at "#{@managed_group_url}"])
page.visit @managed_group_url page.visit @managed_group_url
Support::Waiter.wait { current_url == @managed_group_url } Support::Waiter.wait { current_url == @managed_group_url }
......
...@@ -8,7 +8,7 @@ module QA ...@@ -8,7 +8,7 @@ module QA
module Page module Page
class Login < Page::Base class Login < Page::Base
def login(username, password) def login(username, password)
QA::Runtime::Logger.debug("Logging into SAMLIdp with username: #{username} and password:#{password}") if QA::Runtime::Env.debug? QA::Runtime::Logger.debug("Logging into SAMLIdp with username: #{username} and password:#{password}")
fill_in 'username', with: username fill_in 'username', with: username
fill_in 'password', with: password fill_in 'password', with: password
...@@ -21,7 +21,7 @@ module QA ...@@ -21,7 +21,7 @@ module QA
def login_required? def login_required?
login_required = page.has_text?('Enter your username and password') login_required = page.has_text?('Enter your username and password')
QA::Runtime::Logger.debug("login_required: #{login_required}") if QA::Runtime::Env.debug? QA::Runtime::Logger.debug("login_required: #{login_required}")
login_required login_required
end end
end end
......
...@@ -20,7 +20,7 @@ RSpec.configure do |config| ...@@ -20,7 +20,7 @@ RSpec.configure do |config|
QA::Specs::Helpers::Quarantine.configure_rspec QA::Specs::Helpers::Quarantine.configure_rspec
config.before do |example| config.before do |example|
QA::Runtime::Logger.debug("\nStarting test: #{example.full_description}\n") if QA::Runtime::Env.debug? QA::Runtime::Logger.debug("\nStarting test: #{example.full_description}\n")
end end
config.after(:context) do config.after(:context) do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment