Commit ee1afaf1 authored by Max Woolf's avatar Max Woolf

Merge branch 'john-mason-add-erb-haml-backend-required' into 'master'

Suggest backend reviewer for view files not .svg

See merge request gitlab-org/gitlab!81542
parents 8dffd540 0ef97f29
...@@ -44,7 +44,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do ...@@ -44,7 +44,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do
'ee/README' | [:unknown] 'ee/README' | [:unknown]
'app/assets/foo' | [:frontend] 'app/assets/foo' | [:frontend]
'app/views/foo' | [:frontend] 'app/views/foo' | [:frontend, :backend]
'public/foo' | [:frontend] 'public/foo' | [:frontend]
'scripts/frontend/foo' | [:frontend] 'scripts/frontend/foo' | [:frontend]
'spec/frontend/bar' | [:frontend] 'spec/frontend/bar' | [:frontend]
...@@ -58,7 +58,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do ...@@ -58,7 +58,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do
'config/deep/foo.js' | [:frontend] 'config/deep/foo.js' | [:frontend]
'ee/app/assets/foo' | [:frontend] 'ee/app/assets/foo' | [:frontend]
'ee/app/views/foo' | [:frontend] 'ee/app/views/foo' | [:frontend, :backend]
'ee/spec/frontend/bar' | [:frontend] 'ee/spec/frontend/bar' | [:frontend]
'ee/spec/frontend_integration/bar' | [:frontend] 'ee/spec/frontend_integration/bar' | [:frontend]
...@@ -231,9 +231,12 @@ RSpec.describe Tooling::Danger::ProjectHelper do ...@@ -231,9 +231,12 @@ RSpec.describe Tooling::Danger::ProjectHelper do
'ee/app/assets/javascripts/integrations/zentao/issues_list/graphql/queries/get_zentao_issues.query.graphql' | [:integrations_fe, :frontend] 'ee/app/assets/javascripts/integrations/zentao/issues_list/graphql/queries/get_zentao_issues.query.graphql' | [:integrations_fe, :frontend]
'app/assets/javascripts/pages/projects/settings/integrations/show/index.js' | [:integrations_fe, :frontend] 'app/assets/javascripts/pages/projects/settings/integrations/show/index.js' | [:integrations_fe, :frontend]
'ee/app/assets/javascripts/pages/groups/hooks/index.js' | [:integrations_fe, :frontend] 'ee/app/assets/javascripts/pages/groups/hooks/index.js' | [:integrations_fe, :frontend]
'app/views/clusters/clusters/_integrations_tab.html.haml' | [:frontend] 'app/views/clusters/clusters/_integrations_tab.html.haml' | [:frontend, :backend]
'app/assets/javascripts/alerts_settings/graphql/fragments/integration_item.fragment.graphql' | [:frontend] 'app/assets/javascripts/alerts_settings/graphql/fragments/integration_item.fragment.graphql' | [:frontend]
'app/assets/javascripts/filtered_search/droplab/hook_input.js' | [:frontend] 'app/assets/javascripts/filtered_search/droplab/hook_input.js' | [:frontend]
'app/views/layouts/header/_default.html.haml' | [:frontend, :backend]
'app/views/layouts/header/_default.html.erb' | [:frontend, :backend]
end end
with_them do with_them do
......
...@@ -74,7 +74,9 @@ module Tooling ...@@ -74,7 +74,9 @@ module Tooling
spec/frontend/tracking/.*\.js | spec/frontend/tracking/.*\.js |
spec/frontend/tracking_spec\.js spec/frontend/tracking_spec\.js
)\z}x => [:frontend, :product_intelligence], )\z}x => [:frontend, :product_intelligence],
%r{\A((ee|jh)/)?app/(assets|views)/} => :frontend, %r{\A((ee|jh)/)?app/assets/} => :frontend,
%r{\A((ee|jh)/)?app/views/.*\.svg} => :frontend,
%r{\A((ee|jh)/)?app/views/} => [:frontend, :backend],
%r{\A((ee|jh)/)?public/} => :frontend, %r{\A((ee|jh)/)?public/} => :frontend,
%r{\A((ee|jh)/)?spec/(javascripts|frontend|frontend_integration)/} => :frontend, %r{\A((ee|jh)/)?spec/(javascripts|frontend|frontend_integration)/} => :frontend,
%r{\A((ee|jh)/)?vendor/assets/} => :frontend, %r{\A((ee|jh)/)?vendor/assets/} => :frontend,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment