Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ee35c96b
Commit
ee35c96b
authored
Apr 27, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix eslint
parent
85834b64
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
6 deletions
+10
-6
app/assets/javascripts/boards/components/board_sidebar.js
app/assets/javascripts/boards/components/board_sidebar.js
+7
-2
app/assets/javascripts/sidebar/sidebar_mediator.js
app/assets/javascripts/sidebar/sidebar_mediator.js
+1
-1
spec/javascripts/boards/issue_card_spec.js
spec/javascripts/boards/issue_card_spec.js
+2
-3
No files found.
app/assets/javascripts/boards/components/board_sidebar.js
View file @
ee35c96b
...
...
@@ -3,6 +3,7 @@
/* global MilestoneSelect */
/* global LabelsSelect */
/* global Sidebar */
/* global Flash */
import
Vue
from
'
vue
'
;
import
eventHub
from
'
../../sidebar/event_hub
'
;
...
...
@@ -85,10 +86,14 @@ require('./sidebar/remove_issue');
saveAssignees
()
{
this
.
loadingAssignees
=
true
;
function
setLoadingFalse
()
{
this
.
loadingAssignees
=
false
;
}
gl
.
issueBoards
.
BoardsStore
.
detail
.
issue
.
update
(
this
.
endpoint
)
.
then
(
()
=>
this
.
loadingAssignees
=
f
alse
)
.
then
(
setLoadingF
alse
)
.
catch
(()
=>
{
this
.
loadingAssignees
=
false
;
setLoadingFalse
()
;
return
new
Flash
(
'
An error occurred while saving assignees
'
);
});
},
...
...
app/assets/javascripts/sidebar/sidebar_mediator.js
View file @
ee35c96b
...
...
@@ -19,7 +19,7 @@ export default class SidebarMediator {
}
saveAssignees
(
field
)
{
const
selected
=
this
.
store
.
assignees
.
map
(
(
u
)
=>
u
.
id
);
const
selected
=
this
.
store
.
assignees
.
map
(
u
=>
u
.
id
);
// If there are no ids, that means we have to unassign (which is id = 0)
// And it only accepts an array, hence [0]
...
...
spec/javascripts/boards/issue_card_spec.js
View file @
ee35c96b
...
...
@@ -177,7 +177,6 @@ describe('Issue card component', () => {
expect
(
component
.
$el
.
querySelectorAll
(
'
.card-assignee .avatar
'
).
length
).
toEqual
(
4
);
});
describe
(
'
more than four assignees
'
,
()
=>
{
beforeEach
((
done
)
=>
{
component
.
issue
.
assignees
.
push
(
new
ListAssignee
({
...
...
@@ -199,7 +198,7 @@ describe('Issue card component', () => {
});
it
(
'
renders 99+ avatar counter
'
,
(
done
)
=>
{
for
(
let
i
=
5
;
i
<
104
;
i
++
)
{
for
(
let
i
=
5
;
i
<
104
;
i
+=
1
)
{
const
u
=
new
ListAssignee
({
id
:
i
,
name
:
'
name
'
,
...
...
@@ -215,7 +214,7 @@ describe('Issue card component', () => {
});
});
});
})
})
;
describe
(
'
labels
'
,
()
=>
{
it
(
'
does not render any
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment