Merge branch 'remove-users_ci_job_token_project_scope_links_added_by_id-fk' into 'master'

Remove FK ci_job_token_project_scope_links to users

See merge request gitlab-org/gitlab!78162

db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb

+# frozen_string_literal: true
+
+class RemoveUsersCiJobTokenProjectScopeLinksAddedByIdFk < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    with_lock_retries do
+      remove_foreign_key_if_exists(:ci_job_token_project_scope_links, :users, name: "fk_rails_35f7f506ce")
+    end
+  end
+
+  def down
+    add_concurrent_foreign_key(:ci_job_token_project_scope_links, :users, name: "fk_rails_35f7f506ce", column: :added_by_id, target_column: :id, on_delete: :nullify)
+  end
+end

db/schema_migrations/20220113035519

+4a90811aace678528b75171868fb178ab885d5aac885048e8eacecaf8b0ee374
\ No newline at end of file

db/structure.sql

@@ -30242,9 +30242,6 @@ ALTER TABLE ONLY metrics_dashboard_annotations
 ALTER TABLE ONLY wiki_page_slugs
     ADD CONSTRAINT fk_rails_358b46be14 FOREIGN KEY (wiki_page_meta_id) REFERENCES wiki_page_meta(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY ci_job_token_project_scope_links
-    ADD CONSTRAINT fk_rails_35f7f506ce FOREIGN KEY (added_by_id) REFERENCES users(id) ON DELETE SET NULL;
-
 ALTER TABLE ONLY board_labels
     ADD CONSTRAINT fk_rails_362b0600a3 FOREIGN KEY (label_id) REFERENCES labels(id) ON DELETE CASCADE;
 

spec/models/ci/job_token/project_scope_link_spec.rb

@@ -9,6 +9,11 @@ RSpec.describe Ci::JobToken::ProjectScopeLink do
 
   let_it_be(:project) { create(:project) }
 
+  it_behaves_like 'cleanup by a loose foreign key' do
+    let!(:parent) { create(:user) }
+    let!(:model) { create(:ci_job_token_project_scope_link, added_by: parent) }
+  end
+
   describe 'unique index' do
     let!(:link) { create(:ci_job_token_project_scope_link) }