Merge branch 'jivanvl-remove-ci-cross-pipeline-artifacts-download-ff' into 'master'

Enable cross pipeline artifacts download [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!63074

app/models/ci/build_dependencies.rb

@@ -143,8 +143,6 @@ module Ci
 
     def specified_cross_pipeline_dependencies
       strong_memoize(:specified_cross_pipeline_dependencies) do
-        next [] unless Feature.enabled?(:ci_cross_pipeline_artifacts_download, processable.project, default_enabled: true)
-
         specified_cross_dependencies.select { |dep| dep[:pipeline] && dep[:artifacts] }
       end
     end

config/feature_flags/development/ci_cross_pipeline_artifacts_download.yml

----
-name: ci_cross_pipeline_artifacts_download
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48342 
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/287622 
-milestone: '13.7'
-type: development
-group: group::continuous integration
-default_enabled: true

ee/spec/models/ee/ci/build_dependencies_spec.rb

@@ -335,15 +335,6 @@ RSpec.describe Ci::BuildDependencies do
       it 'returns both dependencies' do
         is_expected.to contain_exactly(cross_project_dependency, upstream_pipeline_dependency)
       end
-
-      context 'when feature flag `ci_cross_pipeline_artifacts_download` is disabled' do
-        before do
-          stub_feature_flags(ci_cross_pipeline_artifacts_download: false)
-        end
-
-        it { is_expected.to contain_exactly(cross_project_dependency) }
-        it { expect(build_dependencies).to be_valid }
-      end
     end
   end
 end

spec/models/ci/build_dependencies_spec.rb

@@ -187,15 +187,6 @@ RSpec.describe Ci::BuildDependencies do
             it { expect(cross_pipeline_deps).to contain_exactly(upstream_job) }
             it { is_expected.to be_valid }
           end
-
-          context 'when feature flag `ci_cross_pipeline_artifacts_download` is disabled' do
-            before do
-              stub_feature_flags(ci_cross_pipeline_artifacts_download: false)
-            end
-
-            it { expect(cross_pipeline_deps).to be_empty }
-            it { is_expected.to be_valid }
-          end
         end
 
         context 'when same job names exist in other pipelines in the hierarchy' do