Commit eee61387 authored by Filipa Lacerda's avatar Filipa Lacerda

Fixes broken modal in DAST report

parent 31be34d7
...@@ -805,10 +805,19 @@ ...@@ -805,10 +805,19 @@
margin: 0; margin: 0;
line-height: $code_line_height; line-height: $code_line_height;
.btn-open-modal {
padding: 0 5px 4px;
}
.mr-widget-code-quality-list-item { .mr-widget-code-quality-list-item {
display: flex; display: flex;
} }
.mr-widget-code-quality-list-item-modal {
display: flex;
flex-wrap: wrap;
}
.failed .mr-widget-code-quality-icon { .failed .mr-widget-code-quality-icon {
color: $red-500; color: $red-500;
} }
......
---
title: Fix broken CSS in modal for DAST report
merge_request:
author:
type: fixed
<script> <script>
import { s__ } from '~/locale'; import { s__ } from '~/locale';
import { spriteIcon } from '~/lib/utils/common_utils'; import Icon from '~/vue_shared/components/icon.vue';
import expandButton from '~/vue_shared/components/expand_button.vue'; import ExpandButton from '~/vue_shared/components/expand_button.vue';
export default { export default {
name: 'ModalDast', name: 'ModalDast',
components: { components: {
expandButton, ExpandButton,
Icon,
}, },
props: { props: {
title: { title: {
...@@ -27,13 +28,10 @@ ...@@ -27,13 +28,10 @@
instances: { instances: {
type: Array, type: Array,
required: false, required: false,
default: () => [], default: () => ([]),
}, },
}, },
computed: { computed: {
cutIcon() {
return spriteIcon('cut');
},
instancesLabel() { instancesLabel() {
return s__('ciReport|Instances'); return s__('ciReport|Instances');
}, },
...@@ -54,7 +52,7 @@ ...@@ -54,7 +52,7 @@
role="dialog" role="dialog"
> >
<div <div
class="modal-dialog" class="modal-dialog modal-lg"
role="document" role="document"
> >
<div class="modal-content"> <div class="modal-content">
...@@ -83,18 +81,21 @@ ...@@ -83,18 +81,21 @@
<li <li
v-for="(instance, i) in instances" v-for="(instance, i) in instances"
:key="i" :key="i"
class="failed" class="mr-widget-code-quality-list-item-modal failed"
> >
<span <icon
class="mr-widget-code-quality-icon" class="mr-widget-code-quality-icon"
v-html="cutIcon" name="status_failed_borderless"
> :size="32"
</span> />
{{ instance.method }} {{ instance.method }}
<a <a
:href="instance.uri" :href="instance.uri"
target="_blank" target="_blank"
rel="noopener noreferrer nofollow" rel="noopener noreferrer nofollow"
class="prepend-left-5"
> >
{{ instance.uri }} {{ instance.uri }}
</a> </a>
......
...@@ -143,6 +143,7 @@ ...@@ -143,6 +143,7 @@
:href="issue.nameLink" :href="issue.nameLink"
target="_blank" target="_blank"
rel="noopener noreferrer nofollow" rel="noopener noreferrer nofollow"
class="prepend-left-5"
> >
{{ issue.name }} {{ issue.name }}
</a> </a>
...@@ -155,7 +156,7 @@ ...@@ -155,7 +156,7 @@
type="button" type="button"
@click="openDastModal(issue, index)" @click="openDastModal(issue, index)"
data-toggle="modal" data-toggle="modal"
class="btn-link btn-blank" class="btn-link btn-blank btn-open-modal"
:data-target="modalTargetId" :data-target="modalTargetId"
> >
{{ issue.name }} {{ issue.name }}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment