Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ef309143
Commit
ef309143
authored
Jan 18, 2016
by
Hannes Rosenögger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide issues settings when issues are disabled
parent
2154fef2
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
42 additions
and
0 deletions
+42
-0
CHANGELOG
CHANGELOG
+1
-0
app/assets/javascripts/project_new.js.coffee
app/assets/javascripts/project_new.js.coffee
+12
-0
features/project/project.feature
features/project/project.feature
+12
-0
features/steps/project/project.rb
features/steps/project/project.rb
+17
-0
No files found.
CHANGELOG
View file @
ef309143
Please view this file on the master branch, on stable branches it's out of date.
v 8.4.0 (unreleased)
- Hide issues settings when issues are disabled (Hannes Rosenögger)
- Add pagination headers to already paginated API resources
- Properly generate diff of orphan commits, like the first commit in a repository
- Improve the consistency of commit titles, branch names, tag names, issue/MR titles, on their respective project pages
...
...
app/assets/javascripts/project_new.js.coffee
View file @
ef309143
...
...
@@ -4,6 +4,7 @@ class @ProjectNew
$
(
'.project-edit-container'
).
hide
()
$
(
'.save-project-loader'
).
show
()
@
toggleSettings
()
@
toggleSettingsOnclick
()
toggleSettings
:
->
...
...
@@ -12,3 +13,14 @@ class @ProjectNew
$
(
'.merge-request-feature'
).
show
()
else
$
(
'.merge-request-feature'
).
hide
()
checked
=
$
(
"#project_issues_enabled"
).
prop
(
"checked"
)
if
checked
$
(
'.issues-feature'
).
show
()
else
$
(
'.issues-feature'
).
hide
()
toggleSettingsOnclick
:
->
$
(
"#project_merge_requests_enabled"
).
on
'click'
,
=>
@
toggleSettings
()
$
(
"#project_issues_enabled"
).
on
'click'
,
=>
@
toggleSettings
()
features/project/project.feature
View file @
ef309143
...
...
@@ -18,6 +18,18 @@ Feature: Project
Then
I should see the default project avatar
And
I should not see the
"Remove avatar"
button
@javascript
Scenario
:
I
disable issues
Given
I visit edit project
"Shop"
page
When
I disable project issues
Then
I should not see the issues settings
@javascript
Scenario
:
I
enable issues
Given
I visit edit project
"Shop"
page
When
I enable project issues
Then
I should see the issues settings
Scenario
:
I
should have back to group button
And
project
"Shop"
belongs to group
And
I visit project
"Shop"
page
...
...
features/steps/project/project.rb
View file @
ef309143
...
...
@@ -177,4 +177,21 @@ class Spinach::Features::Project < Spinach::FeatureSteps
expect
(
page
).
to
have_content
'Notification settings saved'
end
end
step
'I enable project issues'
do
check
'project_issues_enabled'
end
step
'I disable project issues'
do
uncheck
'project_issues_enabled'
end
step
'I should not see the issues settings'
do
expect
(
find
(
'.issues-feature'
)).
not_to
be_visible
end
step
'I should see the issues settings'
do
expect
(
find
(
'.issues-feature'
)).
to
be_visible
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment