Refactor pulling dataset from Vue root element

ef5b6882 · peterhegman · 959dc60e · ef5b6882
Commit ef5b6882 authored Jul 01, 2020 by peterhegman
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

ee/app/assets/javascripts/groups/settings/allowed_email_domains/index.js ...avascripts/groups/settings/allowed_email_domains/index.js +2 -5

No files found.
--- a/ee/app/assets/javascripts/groups/settings/allowed_email_domains/index.js
+++ b/ee/app/assets/javascripts/groups/settings/allowed_email_domains/index.js
@@ -10,12 +10,9 @@ export default () => {
      CommaSeparatedListTokenSelector,
    },
    data() {
-      const { dataset } = document.querySelector(this.$options.el);
+      const { hiddenInputId, labelId } = document.querySelector(this.$options.el).dataset;

-      return {
-        hiddenInputId: dataset.hiddenInputId,
-        labelId: dataset.labelId,
-      };
+      return { hiddenInputId, labelId };
    },
    render(createElement) {
      return createElement('comma-separated-list-token-selector', {