Resolve no search result click causing issue

efb7d43d · Scott Stern · Andrew Fontaine · 7e369ce4 · efb7d43d
Commit efb7d43d authored Jun 01, 2020 by Scott Stern Committed by Andrew Fontaine Jun 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

app/assets/javascripts/milestone_select.js app/assets/javascripts/milestone_select.js +6 -3

No files found.
--- a/app/assets/javascripts/milestone_select.js
+++ b/app/assets/javascripts/milestone_select.js
@@ -130,10 +130,13 @@ export default class MilestoneSelect {
        fieldName: $dropdown.data('fieldName'),
        text: milestone => escape(milestone.title),
        id: milestone => {
-          if (!useId && !$dropdown.is('.js-issuable-form-dropdown')) {
+          if (milestone !== undefined) {
-            return milestone.name;
+            if (!useId && !$dropdown.is('.js-issuable-form-dropdown')) {
+              return milestone.name;
+            }
+            return milestone.id;
          }
-          return milestone.id;
        },
        hidden: () => {
          $selectBox.hide();