Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
efd7dde9
Commit
efd7dde9
authored
Jul 20, 2020
by
Ezekiel Kigbo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Minor fix modal button variant
parent
7260ed2b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
14 deletions
+2
-14
ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue
...lytics/cycle_analytics/components/value_stream_select.vue
+1
-2
ee/spec/frontend/analytics/cycle_analytics/components/value_stream_select_spec.js
...cs/cycle_analytics/components/value_stream_select_spec.js
+0
-11
ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js
...rontend/analytics/cycle_analytics/store/mutations_spec.js
+1
-1
No files found.
ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue
View file @
efd7dde9
...
...
@@ -86,7 +86,6 @@ export default {
onSubmit
()
{
const
{
name
}
=
this
;
return
this
.
createValueStream
({
name
}).
then
(()
=>
{
this
.
$refs
.
modal
.
hide
();
this
.
$toast
.
show
(
sprintf
(
__
(
"
'%{name}' Value Stream created
"
),
{
name
}),
{
position
:
'
top-center
'
,
});
...
...
@@ -141,7 +140,7 @@ export default {
:action-primary=
"
{
text: __('Create value stream'),
attributes: [
{ variant: '
primary
' },
{ variant: '
success
' },
{
disabled: !isValid,
},
...
...
ee/spec/frontend/analytics/cycle_analytics/components/value_stream_select_spec.js
View file @
efd7dde9
...
...
@@ -13,7 +13,6 @@ describe('ValueStreamSelect', () => {
const
createValueStreamMock
=
jest
.
fn
(()
=>
Promise
.
resolve
());
const
mockEvent
=
{
preventDefault
:
jest
.
fn
()
};
const
mockModalHide
=
jest
.
fn
();
const
mockToastShow
=
jest
.
fn
();
const
fakeStore
=
({
initialState
=
{}
})
=>
...
...
@@ -110,7 +109,6 @@ describe('ValueStreamSelect', () => {
beforeEach
(()
=>
{
wrapper
=
createComponent
({
data
:
{
name
:
streamName
}
});
wrapper
.
vm
.
$refs
.
modal
.
hide
=
mockModalHide
;
});
it
(
'
submit button is enabled
'
,
()
=>
{
...
...
@@ -135,10 +133,6 @@ describe('ValueStreamSelect', () => {
position
:
'
top-center
'
,
});
});
it
(
'
hides the modal
'
,
()
=>
{
expect
(
mockModalHide
).
toHaveBeenCalled
();
});
});
describe
(
'
form submission fails
'
,
()
=>
{
...
...
@@ -151,7 +145,6 @@ describe('ValueStreamSelect', () => {
createValueStream
:
()
=>
createValueStreamMockFail
,
},
});
wrapper
.
vm
.
$refs
.
modal
.
hide
=
mockModalHide
;
});
it
(
'
does not clear the name field
'
,
()
=>
{
...
...
@@ -161,10 +154,6 @@ describe('ValueStreamSelect', () => {
it
(
'
does not display a toast message
'
,
()
=>
{
expect
(
mockToastShow
).
not
.
toHaveBeenCalled
();
});
it
(
'
does not hide the modal
'
,
()
=>
{
expect
(
mockModalHide
).
not
.
toHaveBeenCalled
();
});
});
});
});
...
...
ee/spec/frontend/analytics/cycle_analytics/store/mutations_spec.js
View file @
efd7dde9
...
...
@@ -70,7 +70,7 @@ describe('Cycle analytics mutations', () => {
'
$mutation with payload $payload will update state with $expectedState
'
,
({
mutation
,
payload
,
expectedState
})
=>
{
state
=
{
valueStreams
,
valueStreams
,
selectedGroup
:
{
fullPath
:
'
rad-stage
'
},
};
mutations
[
mutation
](
state
,
payload
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment