Merge branch '263222-remove-soft-fail-count-by-state-ff' into 'master'

Remove the soft_fail_count_by_state feature flag

See merge request gitlab-org/gitlab!46350

app/finders/issuable_finder.rb

@@ -153,10 +153,8 @@ class IssuableFinder
   end
 
   def row_count
-    fast_fail = Feature.enabled?(:soft_fail_count_by_state, params.group || params.project)
-
     Gitlab::IssuablesCountForState
-      .new(self, nil, fast_fail: fast_fail)
+      .new(self, nil, fast_fail: true)
       .for_state_or_opened(params[:state])
   end
 

changelogs/unreleased/263222-remove-soft-fail-count-by-state-ff.yml

+---
+title: Gracefully degrade when counting takes too long for a filtered search
+merge_request: 46350
+author:
+type: performance

config/feature_flags/development/soft_fail_count_by_state.yml

----
-name: soft_fail_count_by_state
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/44184
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/263222
-type: development
-group: group::source code
-default_enabled: false

doc/administration/monitoring/prometheus/gitlab_metrics.md

@@ -124,8 +124,6 @@ The following metrics can be controlled by feature flags:
 |:---------------------------------------------------------------|:-------------------------------------------------------------------|
 | `gitlab_method_call_duration_seconds`                          | `prometheus_metrics_method_instrumentation`                        |
 | `gitlab_view_rendering_duration_seconds`                       | `prometheus_metrics_view_instrumentation`                          |
-| `gitlab_issuable_fast_count_by_state_total`                    | `soft_fail_count_by_state` |
-| `gitlab_issuable_fast_count_by_state_failures_total`           | `soft_fail_count_by_state` |
 
 ## Sidekiq metrics