Merge branch 'migrate-ee-changelog-files' into 'master'

Migrate EE changelog files to commits and fix static analysis  [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!62299

.gitlab/ci/yaml.gitlab-ci.yml

@@ -10,5 +10,4 @@ lint-yaml:
   variables:
     LINT_PATHS: .gitlab-ci.yml .gitlab/ci lib/gitlab/ci/templates changelogs
   script:
-    - '[[ ! -d "ee/" ]] || export LINT_PATHS="$LINT_PATHS ee/changelogs"'
     - yamllint -f colored $LINT_PATHS

ee/changelogs/233139-scim_finder_to_support_email_fragment_as_username.yml

----
-title: SCIM get users API to search for email fragment as username
-merge_request: 38807
-author:
-type: changed

ee/changelogs/322079-allow-overnight-oncall-shifts.yml

----
-title: Allow overnight shifts for oncall rotations
-merge_request: 57202
-author:
-type: added

ee/changelogs/323627-add-members-oncall-schedule-data-to-helper.yml

----
-title: Add oncall schedule data to member user API
-merge_request: 58848
-author:
-type: added

ee/changelogs/geo-fix-oauth-redirect.yml

----
-title: 'Geo: Fix sign in on secondary with relative URL'
-merge_request: 37445
-author:
-type: fixed

ee/changelogs/security-360-prevent-any-users-from-deleting-metrics-issue-images.yml

----
-title: Fix permissions for modifying issue metric images
-merge_request:
-author:
-type: security

ee/changelogs/unreleased-ee/alexives-35913-geo_pause_via_api.yml

----
-title: Add rake geo:replication:pause to pause replication from a secondary node
-merge_request: 29515
-author:
-type: added

ee/changelogs/unreleased-ee/alexives-35913-update_ui_remove_pause_button.yml

----
-title: Update node ui to have status indicator instead of button for replication
-merge_request: 34571
-author:
-type: added

ee/changelogs/unreleased/208330-operations-clean-up.yml

----
-title: Update Operations settings forms to be UX consistent
-merge_request: 62034
-author:
-type: changed

ee/changelogs/unreleased/268356-add-escalation-policy-graphql.yml

----
-title: Add GraphQL types for escalation policies and rules
-merge_request: 61439
-author:
-type: added

ee/changelogs/unreleased/287676-remove-threat-monitoring-alert-ff.yml

----
-title: Remove threat_monitoring_alerts feature flag
-merge_request: 62148
-author:
-type: other

ee/changelogs/unreleased/321742-elasticsearch-index_exists-check-should-only-happen-when-changi.yml

----
-title: Only check index status if modifying Advanced Search form
-merge_request: 62135
-author:
-type: fixed

ee/changelogs/unreleased/326721-remove-load-balancing-ff.yml

----
-title: 'Advanced Search: Allow indexing workers to use replicas'
-merge_request: 61993
-author:
-type: performance

ee/changelogs/unreleased/326838-remove-code-owner-banner.yml

----
-title: Remove code owner ribbon move announcement from settings
-merge_request: 62069
-author:
-type: changed

ee/changelogs/unreleased/329702-implement-pluralization-logic-for-single-stat-metrics.yml

----
-title: 'VSA: Add decimal places to metrics'
-merge_request: 62188
-author:
-type: other

ee/changelogs/unreleased/330801-move-gosec-to-alphabetical-order.yml

----
-title: Move gosec to alphabetical order
-merge_request: 61948
-author:
-type: changed

ee/changelogs/unreleased/georgekoltsov-import-export-epic-labels.yml

----
-title: Preserve epic labels association during Group Import/Export
-merge_request: 62074
-author:
-type: fixed

ee/changelogs/unreleased/philipcunningham-add-internal-api-to-update-dast-validation-status-324.yml

----
-title: Add dast_runner_site_validation feature flag
-merge_request: 61649
-author:
-type: added

ee/changelogs/unreleased/prevent-play-job-without-cc-info.yml

----
-title: Check for credit card when playing manual jobs
-merge_request: 62124
-author:
-type: fixed

ee/changelogs/unreleased/vs-hide-plans-with-hide-card-attr.yml

----
-title: Hide billing plans with truthy hide_card attribute
-merge_request: 61990
-author:
-type: fixed

scripts/lint-changelog-filenames

-#!/bin/sh
-
-lint_paths="changelogs/unreleased"
-[ -d "ee/" ] && lint_paths="$lint_paths ee/changelogs/unreleased"
-
-invalid_files=$(find $lint_paths -type f -not -name "*.yml" -not -name ".gitkeep")
-
-if [ -n "$invalid_files" ]; then
-  echo "Changelog files must end in .yml, but these did not:"
-  echo "$invalid_files" | sed -e "s/^/* /"
-  exit 1
-fi

scripts/static-analysis

@@ -38,8 +38,7 @@ class StaticAnalysis
     %w[yarn run block-dependencies] => 0.35,
     %w[scripts/lint-rugged] => 0.23,
     %w[scripts/gemfile_lock_changed.sh] => 0.02,
-    %w[scripts/frontend/check_no_partial_karma_jest.sh] => 0.01,
-    %w[scripts/lint-changelog-filenames] => 0.01
+    %w[scripts/frontend/check_no_partial_karma_jest.sh] => 0.01
   }.reject { |k| k.nil? }.sort_by { |a| -a[1] }.to_h.keys.freeze
 
   def run_tasks!

spec/tooling/danger/project_helper_spec.rb

@@ -162,8 +162,6 @@ RSpec.describe Tooling::Danger::ProjectHelper do
       'workhorse/main.go' | [:workhorse]
       'workhorse/internal/upload/upload.go' | [:workhorse]
 
-      'changelogs/foo'    | [:none]
-      'ee/changelogs/foo' | [:none]
       'locale/gitlab.pot' | [:none]
 
       'FOO'          | [:unknown]

tooling/danger/project_helper.rb

@@ -38,8 +38,6 @@ module Tooling
 
         %r{\A(ee/)?config/feature_flags/} => :feature_flag,
 
-        %r{\A(ee/)?(changelogs/unreleased)(-ee)?/} => :changelog,
-
         %r{\Adoc/development/usage_ping/dictionary\.md\z} => [:docs, :product_intelligence],
         %r{\Adoc/.*(\.(md|png|gif|jpg))\z} => :docs,
         %r{\A(CONTRIBUTING|LICENSE|MAINTENANCE|PHILOSOPHY|PROCESS|README)(\.md)?\z} => :docs,