Merge branch 'epic-6767-e-refactor-IncludeUrlHelpers' into 'master'

Stop using UrlHelper includes in integrations

See merge request gitlab-org/gitlab!81379

.rubocop_todo/rails/include_url_helper.yml

 ---
 Rails/IncludeUrlHelper:
   Exclude:
-  - app/models/integrations/asana.rb
-  - app/models/integrations/bamboo.rb
-  - app/models/integrations/bugzilla.rb
-  - app/models/integrations/campfire.rb
-  - app/models/integrations/confluence.rb
-  - app/models/integrations/custom_issue_tracker.rb
-  - app/models/integrations/discord.rb
-  - app/models/integrations/ewm.rb
-  - app/models/integrations/external_wiki.rb
-  - app/models/integrations/flowdock.rb
-  - app/models/integrations/hangouts_chat.rb
-  - app/models/integrations/irker.rb
-  - app/models/integrations/jenkins.rb
-  - app/models/integrations/mattermost.rb
-  - app/models/integrations/pivotaltracker.rb
-  - app/models/integrations/redmine.rb
-  - app/models/integrations/webex_teams.rb
-  - app/models/integrations/youtrack.rb
-  - ee/app/models/integrations/github.rb
   - ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb
   - ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb
   - spec/helpers/merge_requests_helper_spec.rb

app/models/integrations/asana.rb

@@ -4,8 +4,6 @@ require 'asana'
 
 module Integrations
   class Asana < Integration
-    include ActionView::Helpers::UrlHelper
-
     prop_accessor :api_key, :restrict_to_branch
     validates :api_key, presence: true, if: :activated?
 
@@ -18,7 +16,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/asana'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/asana'), target: '_blank', rel: 'noopener noreferrer'
       s_('Add commit messages as comments to Asana tasks. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/bamboo.rb

@@ -2,7 +2,6 @@
 
 module Integrations
   class Bamboo < BaseCi
-    include ActionView::Helpers::UrlHelper
     include ReactivelyCached
     prepend EnableSslVerification
 
@@ -36,7 +35,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/bamboo'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/bamboo'), target: '_blank', rel: 'noopener noreferrer'
       s_('BambooService|Run CI/CD pipelines with Atlassian Bamboo. You must set up automatic revision labeling and a repository trigger in Bamboo. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/bugzilla.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Bugzilla < BaseIssueTracker
-    include ActionView::Helpers::UrlHelper
-
     validates :project_url, :issues_url, :new_issue_url, presence: true, public_url: true, if: :activated?
 
     def title
@@ -15,7 +13,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/bugzilla'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/bugzilla'), target: '_blank', rel: 'noopener noreferrer'
       s_("IssueTracker|Use Bugzilla as this project's issue tracker. %{docs_link}").html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/campfire.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Campfire < Integration
-    include ActionView::Helpers::UrlHelper
-
     prop_accessor :token, :subdomain, :room
     validates :token, presence: true, if: :activated?
 
@@ -16,7 +14,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('api/services', anchor: 'campfire'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('api/services', anchor: 'campfire'), target: '_blank', rel: 'noopener noreferrer'
       s_('CampfireService|Send notifications about push events to Campfire chat rooms. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/confluence.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Confluence < Integration
-    include ActionView::Helpers::UrlHelper
-
     VALID_SCHEME_MATCH = %r{\Ahttps?\Z}.freeze
     VALID_HOST_MATCH = %r{\A.+\.atlassian\.net\Z}.freeze
     VALID_PATH_MATCH = %r{\A/wiki(/|\Z)}.freeze
@@ -39,7 +37,7 @@ module Integrations
 
         s_(
           'ConfluenceService|Your GitLab wiki is still available at %{wiki_link}. To re-enable the link to the GitLab wiki, disable this integration.' %
-          { wiki_link: link_to(wiki_url, wiki_url) }
+          { wiki_link: ActionController::Base.helpers.link_to(wiki_url, wiki_url) }
         ).html_safe
       else
         s_('ConfluenceService|Link to a Confluence Workspace from the sidebar. Enabling this integration replaces the "Wiki" sidebar link with a link to the Confluence Workspace. The GitLab wiki is still available at the original URL.').html_safe

app/models/integrations/custom_issue_tracker.rb

@@ -2,7 +2,6 @@
 
 module Integrations
   class CustomIssueTracker < BaseIssueTracker
-    include ActionView::Helpers::UrlHelper
     validates :project_url, :issues_url, :new_issue_url, presence: true, public_url: true, if: :activated?
 
     def title
@@ -14,7 +13,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/custom_issue_tracker'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/custom_issue_tracker'), target: '_blank', rel: 'noopener noreferrer'
       s_('IssueTracker|Use a custom issue tracker that is not in the integration list. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/discord.rb

@@ -4,8 +4,6 @@ require "discordrb/webhooks"
 
 module Integrations
   class Discord < BaseChatNotification
-    include ActionView::Helpers::UrlHelper
-
     ATTACHMENT_REGEX = /: (?<entry>.*?)\n - (?<name>.*)\n*/.freeze
 
     def title
@@ -21,7 +19,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('How do I set up this service?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/discord_notifications'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('How do I set up this service?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/discord_notifications'), target: '_blank', rel: 'noopener noreferrer'
       s_('Send notifications about project events to a Discord channel. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/ewm.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Ewm < BaseIssueTracker
-    include ActionView::Helpers::UrlHelper
-
     validates :project_url, :issues_url, :new_issue_url, presence: true, public_url: true, if: :activated?
 
     def self.reference_pattern(only_long: true)
@@ -19,7 +17,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/ewm'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/ewm'), target: '_blank', rel: 'noopener noreferrer'
       s_("IssueTracker|Use IBM Engineering Workflow Management as this project's issue tracker. %{docs_link}").html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/external_wiki.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class ExternalWiki < Integration
-    include ActionView::Helpers::UrlHelper
-
     prop_accessor :external_wiki_url
     validates :external_wiki_url, presence: true, public_url: true, if: :activated?
 
@@ -33,7 +31,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/wiki/index', anchor: 'link-an-external-wiki'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/wiki/index', anchor: 'link-an-external-wiki'), target: '_blank', rel: 'noopener noreferrer'
 
       s_('Link an external wiki from the project\'s sidebar. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end

app/models/integrations/flowdock.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Flowdock < Integration
-    include ActionView::Helpers::UrlHelper
-
     prop_accessor :token
     validates :token, presence: true, if: :activated?
 
@@ -16,7 +14,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('api/services', anchor: 'flowdock'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('api/services', anchor: 'flowdock'), target: '_blank', rel: 'noopener noreferrer'
       s_('FlowdockService|Send event notifications from GitLab to Flowdock flows. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/hangouts_chat.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class HangoutsChat < BaseChatNotification
-    include ActionView::Helpers::UrlHelper
-
     def title
       'Google Chat'
     end
@@ -17,7 +15,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('How do I set up a Google Chat webhook?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/hangouts_chat'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('How do I set up a Google Chat webhook?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/hangouts_chat'), target: '_blank', rel: 'noopener noreferrer'
       s_('Before enabling this integration, create a webhook for the room in Google Chat where you want to receive notifications from this project. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/irker.rb

@@ -4,8 +4,6 @@ require 'uri'
 
 module Integrations
   class Irker < Integration
-    include ActionView::Helpers::UrlHelper
-
     prop_accessor :server_host, :server_port, :default_irc_uri
     prop_accessor :recipients, :channels
     boolean_accessor :colorize_messages
@@ -44,7 +42,7 @@ module Integrations
     end
 
     def fields
-      recipients_docs_link = link_to s_('IrkerService|How to enter channels or users?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/irker', anchor: 'enter-irker-recipients'), target: '_blank', rel: 'noopener noreferrer'
+      recipients_docs_link = ActionController::Base.helpers.link_to s_('IrkerService|How to enter channels or users?'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/irker', anchor: 'enter-irker-recipients'), target: '_blank', rel: 'noopener noreferrer'
       [
         { type: 'text', name: 'server_host', placeholder: 'localhost', title: s_('IrkerService|Server host (optional)'),
           help: s_('IrkerService|irker daemon hostname (defaults to localhost).') },
@@ -61,7 +59,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/irker', anchor: 'set-up-an-irker-daemon'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/irker', anchor: 'set-up-an-irker-daemon'), target: '_blank', rel: 'noopener noreferrer'
       s_('IrkerService|Send update messages to an irker server. Before you can use this, you need to set up the irker daemon. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/jenkins.rb

@@ -3,7 +3,7 @@
 module Integrations
   class Jenkins < BaseCi
     include HasWebHook
-    include ActionView::Helpers::UrlHelper
+
     prepend EnableSslVerification
     extend Gitlab::Utils::Override
 
@@ -65,7 +65,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('integration/jenkins'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('integration/jenkins'), target: '_blank', rel: 'noopener noreferrer'
       s_('Run CI/CD pipelines with Jenkins when you push to a repository, or when a merge request is created, updated, or merged. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/mattermost.rb

@@ -3,7 +3,6 @@
 module Integrations
   class Mattermost < BaseChatNotification
     include SlackMattermostNotifier
-    include ActionView::Helpers::UrlHelper
 
     def title
       s_('Mattermost notifications')
@@ -18,7 +17,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/mattermost'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/mattermost'), target: '_blank', rel: 'noopener noreferrer'
       s_('Send notifications about project events to Mattermost channels. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/pivotaltracker.rb

@@ -2,7 +2,6 @@
 
 module Integrations
   class Pivotaltracker < Integration
-    include ActionView::Helpers::UrlHelper
     API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'
 
     prop_accessor :token, :restrict_to_branch
@@ -17,7 +16,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/pivotal_tracker'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/pivotal_tracker'), target: '_blank', rel: 'noopener noreferrer'
       s_('Add commit messages as comments to Pivotal Tracker stories. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/redmine.rb

@@ -2,7 +2,6 @@
 
 module Integrations
   class Redmine < BaseIssueTracker
-    include ActionView::Helpers::UrlHelper
     validates :project_url, :issues_url, :new_issue_url, presence: true, public_url: true, if: :activated?
 
     def title
@@ -14,7 +13,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/redmine'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/redmine'), target: '_blank', rel: 'noopener noreferrer'
       s_('IssueTracker|Use Redmine as the issue tracker. %{docs_link}').html_safe % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/webex_teams.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class WebexTeams < BaseChatNotification
-    include ActionView::Helpers::UrlHelper
-
     def title
       s_("WebexTeamsService|Webex Teams")
     end
@@ -17,7 +15,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/webex_teams'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/webex_teams'), target: '_blank', rel: 'noopener noreferrer'
       s_("WebexTeamsService|Send notifications about project events to a Webex Teams conversation. %{docs_link}") % { docs_link: docs_link.html_safe }
     end
 

app/models/integrations/youtrack.rb

@@ -2,8 +2,6 @@
 
 module Integrations
   class Youtrack < BaseIssueTracker
-    include ActionView::Helpers::UrlHelper
-
     validates :project_url, :issues_url, presence: true, public_url: true, if: :activated?
 
     # {PROJECT-KEY}-{NUMBER} Examples: YT-1, PRJ-1, gl-030
@@ -24,7 +22,7 @@ module Integrations
     end
 
     def help
-      docs_link = link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/youtrack'), target: '_blank', rel: 'noopener noreferrer'
+      docs_link = ActionController::Base.helpers.link_to _('Learn more.'), Rails.application.routes.url_helpers.help_page_url('user/project/integrations/youtrack'), target: '_blank', rel: 'noopener noreferrer'
       s_("IssueTracker|Use YouTrack as this project's issue tracker. %{docs_link}").html_safe % { docs_link: docs_link.html_safe }
     end
 

ee/app/models/integrations/github.rb

@@ -3,7 +3,6 @@
 module Integrations
   class Github < Integration
     include Gitlab::Routing
-    include ActionView::Helpers::UrlHelper
 
     prop_accessor :token, :repository_url
     boolean_accessor :static_context
@@ -30,7 +29,7 @@ module Integrations
     def help
       return unless project
 
-      docs_link = link_to _('What is repository mirroring?'), help_page_url('user/project/repository/repository_mirroring')
+      docs_link = ActionController::Base.helpers.link_to _('What is repository mirroring?'), help_page_url('user/project/repository/repository_mirroring')
       s_("GithubIntegration|This requires mirroring your GitHub repository to this project. %{docs_link}" % { docs_link: docs_link }).html_safe
     end