Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f5707c27
Commit
f5707c27
authored
Jan 21, 2020
by
Sean Arnold
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor to not use instance var
parent
0ce46ab4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
3 deletions
+5
-3
app/services/error_tracking/issue_update_service.rb
app/services/error_tracking/issue_update_service.rb
+5
-3
No files found.
app/services/error_tracking/issue_update_service.rb
View file @
f5707c27
...
@@ -7,7 +7,9 @@ module ErrorTracking
...
@@ -7,7 +7,9 @@ module ErrorTracking
def
perform
def
perform
response
=
fetch
response
=
fetch
update_related_issue
unless
parse_errors
(
response
).
present?
unless
parse_errors
(
response
).
present?
response
[
:closed_issue_iid
]
=
update_related_issue
&
.
iid
end
response
response
end
end
...
@@ -23,7 +25,7 @@ module ErrorTracking
...
@@ -23,7 +25,7 @@ module ErrorTracking
issue
=
related_issue
issue
=
related_issue
return
unless
issue
return
unless
issue
@closed_issue
=
close_and_create_note
(
issue
)
close_and_create_note
(
issue
)
end
end
def
close_and_create_note
(
issue
)
def
close_and_create_note
(
issue
)
...
@@ -64,7 +66,7 @@ module ErrorTracking
...
@@ -64,7 +66,7 @@ module ErrorTracking
def
parse_response
(
response
)
def
parse_response
(
response
)
{
{
updated:
response
[
:updated
].
present?
,
updated:
response
[
:updated
].
present?
,
closed_issue_iid:
@closed_issue
&
.
iid
closed_issue_iid:
response
[
:closed_issue_iid
]
}
}
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment