Fix Rails/SaveBang offenses

Changelog: other

.rubocop_todo/rails/save_bang.yml

@@ -63,10 +63,6 @@ Rails/SaveBang:
   - ee/spec/services/status_page/trigger_publish_service_spec.rb
   - ee/spec/services/todo_service_spec.rb
   - ee/spec/services/vulnerability_feedback/create_service_spec.rb
-  - qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb
-  - qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb
-  - qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb
-  - qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb
   - spec/lib/backup/manager_spec.rb
   - spec/lib/gitlab/alerting/alert_spec.rb
   - spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb

qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb

@@ -30,7 +30,7 @@ module QA
             mirror_settings.authentication_method = 'Password'
             mirror_settings.password = Runtime::User.password
             mirror_settings.mirror_repository
-            mirror_settings.update target_project_uri
+            mirror_settings.update target_project_uri # rubocop:disable Rails/SaveBang
           end
         end
 

qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb

@@ -29,7 +29,7 @@ module QA
             mirror_settings.authentication_method = 'Password'
             mirror_settings.password = Runtime::User.password
             mirror_settings.mirror_repository
-            mirror_settings.update target_project_uri
+            mirror_settings.update target_project_uri # rubocop:disable Rails/SaveBang
           end
         end
 

qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb

@@ -29,7 +29,7 @@ module QA
             mirror_settings.authentication_method = 'Password'
             mirror_settings.password = Runtime::User.admin_password
             mirror_settings.mirror_repository
-            mirror_settings.update source_project_uri
+            mirror_settings.update source_project_uri # rubocop:disable Rails/SaveBang
           end
         end
 

qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb

@@ -52,7 +52,7 @@ module QA
         Page::Project::Menu.perform(&:go_to_repository_settings)
         Page::Project::Settings::Repository.perform do |settings|
           settings.expand_mirroring_repositories do |mirror_settings|
-            mirror_settings.update source_project_uri
+            mirror_settings.update source_project_uri # rubocop:disable Rails/SaveBang
           end
         end