Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f620202b
Commit
f620202b
authored
Apr 06, 2020
by
Rajendra Kadam
Committed by
Peter Leitzen
Apr 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove duplicate environment finder spec
parent
4dfbaebf
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
6 deletions
+5
-6
.rubocop.yml
.rubocop.yml
+0
-1
changelogs/unreleased/environment-finder-spec.yml
changelogs/unreleased/environment-finder-spec.yml
+5
-0
spec/finders/environments_finder_spec.rb
spec/finders/environments_finder_spec.rb
+0
-5
No files found.
.rubocop.yml
View file @
f620202b
...
@@ -391,7 +391,6 @@ RSpec/RepeatedExample:
...
@@ -391,7 +391,6 @@ RSpec/RepeatedExample:
-
'
spec/features/issues/filtered_search/filter_issues_spec.rb'
-
'
spec/features/issues/filtered_search/filter_issues_spec.rb'
-
'
spec/features/merge_request/user_posts_diff_notes_spec.rb'
-
'
spec/features/merge_request/user_posts_diff_notes_spec.rb'
-
'
spec/features/projects/files/template_type_dropdown_spec.rb'
-
'
spec/features/projects/files/template_type_dropdown_spec.rb'
-
'
spec/finders/environments_finder_spec.rb'
-
'
spec/helpers/users_helper_spec.rb'
-
'
spec/helpers/users_helper_spec.rb'
-
'
spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
-
'
spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
-
'
spec/services/notification_service_spec.rb'
-
'
spec/services/notification_service_spec.rb'
...
...
changelogs/unreleased/environment-finder-spec.yml
0 → 100644
View file @
f620202b
---
title
:
Fix duplicate spec in environment finder
merge_request
:
28857
author
:
Rajendra Kadam
type
:
added
spec/finders/environments_finder_spec.rb
View file @
f620202b
...
@@ -37,11 +37,6 @@ describe EnvironmentsFinder do
...
@@ -37,11 +37,6 @@ describe EnvironmentsFinder do
.
to
be_empty
.
to
be_empty
end
end
it
'returns environment when with_tags is set'
do
expect
(
described_class
.
new
(
project
,
user
,
ref:
'master'
,
commit:
commit
,
with_tags:
true
).
execute
)
.
to
contain_exactly
(
environment
,
environment_two
)
end
# We expect two Gitaly calls: FindCommit, CommitIsAncestor
# We expect two Gitaly calls: FindCommit, CommitIsAncestor
# This tests to ensure we don't call one CommitIsAncestor per environment
# This tests to ensure we don't call one CommitIsAncestor per environment
it
'only calls Gitaly twice when multiple environments are present'
,
:request_store
do
it
'only calls Gitaly twice when multiple environments are present'
,
:request_store
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment