Merge branch 'sh-cache-push-rule-global-lookup' into 'master'

Memoize the global default for push rules within the request

Closes #6465

See merge request gitlab-org/gitlab-ee!6160

ee/app/models/push_rule.rb

 class PushRule < ActiveRecord::Base
+  extend Gitlab::Cache::RequestCache
+
+  request_cache_key do
+    [self.id]
+  end
+
   MatchError = Class.new(StandardError)
 
   REGEX_COLUMNS = %i[
@@ -131,7 +137,7 @@ class PushRule < ActiveRecord::Base
     !regexp_uses_re2?
   end
 
-  def read_setting_with_global_default(setting)
+  request_cache def read_setting_with_global_default(setting)
     value = read_attribute(setting)
 
     # return if value is true/false or if current object is the global setting

ee/changelogs/unreleased/sh-cache-push-rule-global-lookup.yml

+---
+title: Memoize the global default for push rules within the request
+merge_request:
+author:
+type: performance

ee/spec/models/push_rule_spec.rb

@@ -223,6 +223,21 @@ describe PushRule do
     end
   end
 
+  context 'with caching', :request_store do
+    let(:push_rule_second) { create(:push_rule) }
+
+    it 'memoizes the right push rules' do
+      expect(described_class).to receive(:global).twice.and_return(global_push_rule)
+      expect(global_push_rule).to receive(:public_send).with(:commit_committer_check).and_return(false)
+      expect(global_push_rule).to receive(:public_send).with(:reject_unsigned_commits).and_return(true)
+
+      2.times do
+        expect(push_rule.commit_committer_check).to be_falsey
+        expect(push_rule_second.reject_unsigned_commits).to be_truthy
+      end
+    end
+  end
+
   describe '#available?' do
     shared_examples 'an unavailable push_rule' do
       it 'is not available' do