Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f65eb0e8
Commit
f65eb0e8
authored
Apr 01, 2019
by
Bob Van Landuyt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevent create|destroy design on archived projects
Don't allow modification of designs when a project is archived
parent
33dad3f8
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletion
+15
-1
ee/app/policies/ee/project_policy.rb
ee/app/policies/ee/project_policy.rb
+1
-0
ee/spec/policies/design_management/design_policy_spec.rb
ee/spec/policies/design_management/design_policy_spec.rb
+14
-1
No files found.
ee/app/policies/ee/project_policy.rb
View file @
f65eb0e8
...
@@ -11,6 +11,7 @@ module EE
...
@@ -11,6 +11,7 @@ module EE
vulnerability_feedback
vulnerability_feedback
license_management
license_management
feature_flag
feature_flag
design
]
.
freeze
]
.
freeze
prepended
do
prepended
do
...
...
ee/spec/policies/design_management/design_policy_spec.rb
View file @
f65eb0e8
...
@@ -13,7 +13,7 @@ describe DesignManagement::DesignPolicy do
...
@@ -13,7 +13,7 @@ describe DesignManagement::DesignPolicy do
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
let
(
:design
)
{
create
(
:design
,
issue:
issue
)
}
let
(
:design
)
{
create
(
:design
,
issue:
issue
)
}
subject
{
described_class
.
new
(
current_user
,
design
)
}
subject
(
:design_policy
)
{
described_class
.
new
(
current_user
,
design
)
}
shared_examples_for
"design abilities not available"
do
shared_examples_for
"design abilities not available"
do
context
"for owners"
do
context
"for owners"
do
...
@@ -149,5 +149,18 @@ describe DesignManagement::DesignPolicy do
...
@@ -149,5 +149,18 @@ describe DesignManagement::DesignPolicy do
it
{
is_expected
.
to
be_disallowed
(
*
design_abilities
)
}
it
{
is_expected
.
to
be_disallowed
(
*
design_abilities
)
}
end
end
end
end
context
"when the project is archived"
do
let
(
:current_user
)
{
owner
}
before
do
project
.
update!
(
archived:
true
)
end
it
"only allows reading designs"
do
expect
(
design_policy
).
to
be_allowed
(
:read_design
)
expect
(
design_policy
).
to
be_disallowed
(
:create_design
,
:destroy_design
)
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment