Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f8466f59
Commit
f8466f59
authored
Nov 17, 2021
by
mehulsharma
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix OpenStruct use
Fixed OpenStruct use in dsl_spec as Ruby 3 discourages it Changelog: other
parent
908b60b5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
3 deletions
+2
-3
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-1
spec/lib/gitlab/quick_actions/dsl_spec.rb
spec/lib/gitlab/quick_actions/dsl_spec.rb
+2
-2
No files found.
.rubocop_manual_todo.yml
View file @
f8466f59
...
@@ -2599,7 +2599,6 @@ Style/OpenStructUse:
...
@@ -2599,7 +2599,6 @@ Style/OpenStructUse:
-
'
spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb'
-
'
spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb'
-
'
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb'
-
'
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb'
-
'
spec/lib/gitlab/quick_actions/command_definition_spec.rb'
-
'
spec/lib/gitlab/quick_actions/command_definition_spec.rb'
-
'
spec/lib/gitlab/quick_actions/dsl_spec.rb'
-
'
spec/lib/gitlab/relative_positioning/range_spec.rb'
-
'
spec/lib/gitlab/relative_positioning/range_spec.rb'
-
'
spec/models/design_management/design_action_spec.rb'
-
'
spec/models/design_management/design_action_spec.rb'
-
'
spec/models/design_management/design_at_version_spec.rb'
-
'
spec/models/design_management/design_at_version_spec.rb'
...
...
spec/lib/gitlab/quick_actions/dsl_spec.rb
View file @
f8466f59
...
@@ -96,8 +96,8 @@ RSpec.describe Gitlab::QuickActions::Dsl do
...
@@ -96,8 +96,8 @@ RSpec.describe Gitlab::QuickActions::Dsl do
expect
(
dynamic_description_def
.
name
).
to
eq
(
:dynamic_description
)
expect
(
dynamic_description_def
.
name
).
to
eq
(
:dynamic_description
)
expect
(
dynamic_description_def
.
aliases
).
to
eq
([])
expect
(
dynamic_description_def
.
aliases
).
to
eq
([])
expect
(
dynamic_description_def
.
to_h
(
OpenStruct
.
new
(
noteable:
'issue'
))[
:description
]).
to
eq
(
'A dynamic description for ISSUE'
)
expect
(
dynamic_description_def
.
to_h
(
double
(
'desc'
,
noteable:
'issue'
))[
:description
]).
to
eq
(
'A dynamic description for ISSUE'
)
expect
(
dynamic_description_def
.
execute_message
(
OpenStruct
.
new
(
noteable:
'issue'
),
'arg'
)).
to
eq
(
'A dynamic execution message for ISSUE passing arg'
)
expect
(
dynamic_description_def
.
execute_message
(
double
(
'desc'
,
noteable:
'issue'
),
'arg'
)).
to
eq
(
'A dynamic execution message for ISSUE passing arg'
)
expect
(
dynamic_description_def
.
params
).
to
eq
([
'The first argument'
,
'The second argument'
])
expect
(
dynamic_description_def
.
params
).
to
eq
([
'The first argument'
,
'The second argument'
])
expect
(
dynamic_description_def
.
condition_block
).
to
be_nil
expect
(
dynamic_description_def
.
condition_block
).
to
be_nil
expect
(
dynamic_description_def
.
types
).
to
eq
([])
expect
(
dynamic_description_def
.
types
).
to
eq
([])
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment