Implement upload package logic without workhorse for now

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

app/models/packages/maven_metadatum.rb

 class Packages::MavenMetadatum < ActiveRecord::Base
   belongs_to :package
+
+  validates :package, presence: true
 end

app/models/packages/package.rb

@@ -2,4 +2,6 @@ class Packages::Package < ActiveRecord::Base
   belongs_to :project
   has_many :package_files
   has_one :maven_metadatum
+
+  validates :project, presence: true
 end

app/models/packages/package_file.rb

 class Packages::PackageFile < ActiveRecord::Base
   belongs_to :package
 
+  validates :package, presence: true
+
   mount_uploader :file, PackageFileUploader
 end

app/uploaders/packages/package_file_uploader.rb

@@ -4,6 +4,10 @@ class Packages::PackageFileUploader < GitlabUploader
 
   storage_options Gitlab.config.packages
 
+  def filename
+    model.file_name
+  end
+
   def store_dir
     dynamic_segment
   end

db/migrate/20180720120726_create_packages_package_files.rb

@@ -9,6 +9,7 @@ class CreatePackagesPackageFiles < ActiveRecord::Migration
     create_table :packages_package_files do |t|
       t.references :package, index: true, null: false
       t.string :file
+      t.string :file_name, null: false
       t.integer :file_type
       t.integer :file_store
       t.integer :size

db/schema.rb

@@ -1921,6 +1921,42 @@ ActiveRecord::Schema.define(version: 20180807153545) do
     t.string "nonce", null: false
   end
 
+  create_table "packages_maven_metadata", force: :cascade do |t|
+    t.integer "package_id", null: false
+    t.string "app_group", null: false
+    t.string "app_name", null: false
+    t.string "app_version", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  add_index "packages_maven_metadata", ["package_id"], name: "index_packages_maven_metadata_on_package_id", using: :btree
+
+  create_table "packages_package_files", force: :cascade do |t|
+    t.integer "package_id", null: false
+    t.string "file"
+    t.string "file_name", null: false
+    t.integer "file_type"
+    t.integer "file_store"
+    t.integer "size"
+    t.binary "file_md5"
+    t.binary "file_sha1"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  add_index "packages_package_files", ["package_id"], name: "index_packages_package_files_on_package_id", using: :btree
+
+  create_table "packages_packages", force: :cascade do |t|
+    t.integer "project_id", null: false
+    t.string "name"
+    t.string "version"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  add_index "packages_packages", ["project_id"], name: "index_packages_packages_on_project_id", using: :btree
+
   create_table "pages_domains", force: :cascade do |t|
     t.integer "project_id"
     t.text "certificate"

lib/api/maven_packages.rb

@@ -6,6 +6,8 @@ module API
       file_name: API::NO_SLASH_URL_PART_REGEX
     }.freeze
 
+    MAVEN_METADATA_FILE = 'maven-metadata.xml'.freeze
+
     content_type :md5, 'text/plain'
     content_type :sha1, 'text/plain'
     content_type :binary, 'application/octet-stream'
@@ -42,8 +44,7 @@ module API
                                                        app_name: params[:app_name],
                                                        app_version: params[:app_version])
 
-
-        package_file = metadata.package.package_files.find_by!(file: file_name)
+        package_file = metadata.package.package_files.find_by!(file_name: file_name)
 
         case format
         when 'md5'
@@ -59,7 +60,55 @@ module API
         detail 'This feature was introduced in GitLab 11.3'
       end
       put ':id/packages/maven/*app_group/:app_name/:app_version/:file_name', requirements: MAVEN_ENDPOINT_REQUIREMENTS do
-        # TODO: Implement me
+        file_name, format = extract_format(params[:file_name])
+
+        metadata = ::Packages::MavenMetadatum.find_by(app_group: params[:app_group],
+                                                      app_name: params[:app_name],
+                                                      app_version: params[:app_version])
+
+        if metadata
+          # Everything seems legit. We can proceed to file uploading
+        else
+          if file_name == MAVEN_METADATA_FILE
+            xml = env['api.request.input']
+            version = Nokogiri::XML(xml).css('metadata:root > version').text
+
+            # Skip handling top level maven-metadata.xml for now
+            # Also stop request if version in metadata file differs from one in URL
+            return unless version || version != params[:app_version]
+          end
+
+          package = Packages::Package.crate(project: user_project)
+
+          metadata = ::Packages::MavenMetadatum.crate_by!(
+            project: package.project,
+            app_group: params[:app_group],
+            app_name: params[:app_name],
+            app_version: params[:app_version]
+          )
+        end
+
+        # Convert string into CarrierWave compatible StringIO object
+        string_file = CarrierWaveStringFile.new(env['api.request.input'])
+
+        if format
+          package_file = metadata.package.package_files.find_by!(file_name: file_name)
+
+          case format
+          when 'md5'
+            package_file.file_md5 = string_file
+          when 'sha1'
+            package_file.file_sha1 = string_file
+          end
+
+          package_file.save!
+        else
+          package_file = metadata.package.package_files.new
+          package_file.file_name = file_name
+          package_file.file_type = file_name.rpartition('.').last
+          package_file.file = string_file
+          package_file.save!
+        end
       end
     end
   end

spec/models/packages/maven_metadatum_spec.rb

 require 'rails_helper'
 
 RSpec.describe Packages::MavenMetadatum, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  describe 'relationships' do
+    it { is_expected.to belong_to(:package) }
+  end
+
+  describe 'validations' do
+    it { is_expected.to validate_presence_of(:package) }
+  end
 end

spec/models/packages/package_file_spec.rb

 require 'rails_helper'
 
 RSpec.describe Packages::PackageFile, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  describe 'relationships' do
+    it { is_expected.to belong_to(:package) }
+  end
+
+  describe 'validations' do
+    it { is_expected.to validate_presence_of(:package) }
+  end
 end

spec/models/packages/package_spec.rb

 require 'rails_helper'
 
 RSpec.describe Packages::Package, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  describe 'relationships' do
+    it { is_expected.to belong_to(:project) }
+    it { is_expected.to have_many(:package_files) }
+  end
+
+  describe 'validations' do
+    it { is_expected.to validate_presence_of(:project) }
+  end
 end