Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f9ff17b2
Commit
f9ff17b2
authored
May 06, 2020
by
Miguel Rincon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allows users to single panels in a new tab
parent
071e8dac
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
2 deletions
+14
-2
app/assets/javascripts/monitoring/components/dashboard_panel.vue
...ets/javascripts/monitoring/components/dashboard_panel.vue
+6
-1
changelogs/unreleased/216750-open-single-panel-new-tab.yml
changelogs/unreleased/216750-open-single-panel-new-tab.yml
+5
-0
spec/frontend/monitoring/components/dashboard_panel_spec.js
spec/frontend/monitoring/components/dashboard_panel_spec.js
+3
-1
No files found.
app/assets/javascripts/monitoring/components/dashboard_panel.vue
View file @
f9ff17b2
...
...
@@ -313,7 +313,12 @@ export default {
<template
slot=
"button-content"
>
<gl-icon
name=
"ellipsis_v"
class=
"text-secondary"
/>
</
template
>
<gl-dropdown-item
v-if=
"expandBtnAvailable"
ref=
"expandBtn"
@
click=
"onExpand"
>
<gl-dropdown-item
v-if=
"expandBtnAvailable"
ref=
"expandBtn"
:href=
"clipboardText"
@
click.prevent=
"onExpand"
>
{{ s__('Metrics|Expand panel') }}
</gl-dropdown-item>
<gl-dropdown-item
...
...
changelogs/unreleased/216750-open-single-panel-new-tab.yml
0 → 100644
View file @
f9ff17b2
---
title
:
Allow monitoring dashboard users to open single panels in a new tab
merge_request
:
31206
author
:
type
:
added
spec/frontend/monitoring/components/dashboard_panel_spec.js
View file @
f9ff17b2
...
...
@@ -518,8 +518,10 @@ describe('Dashboard Panel', () => {
});
it
(
'
emits the `expand` event
'
,
()
=>
{
findExpandBtn
().
vm
.
$emit
(
'
click
'
);
const
preventDefault
=
jest
.
fn
();
findExpandBtn
().
vm
.
$emit
(
'
click
'
,
{
preventDefault
});
expect
(
wrapper
.
emitted
(
'
expand
'
)).
toHaveLength
(
1
);
expect
(
preventDefault
).
toHaveBeenCalled
();
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment