Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fa36d3bc
Commit
fa36d3bc
authored
Apr 12, 2021
by
Huzaifa Iftikhar
Committed by
Markus Koller
Apr 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/hook_data
parent
50cf235d
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
3 deletions
+8
-3
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-3
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-hook-data.yml
...25836-fix-empty-line-after-let-it-be-gitlab-hook-data.yml
+5
-0
spec/lib/gitlab/hook_data/issue_builder_spec.rb
spec/lib/gitlab/hook_data/issue_builder_spec.rb
+1
-0
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
+1
-0
spec/lib/gitlab/hook_data/release_builder_spec.rb
spec/lib/gitlab/hook_data/release_builder_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
fa36d3bc
...
...
@@ -784,9 +784,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
spec/lib/gitlab/gitaly_client/operation_service_spec.rb
-
spec/lib/gitlab/gl_repository/repo_type_spec.rb
-
spec/lib/gitlab/group_search_results_spec.rb
-
spec/lib/gitlab/hook_data/issue_builder_spec.rb
-
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
-
spec/lib/gitlab/hook_data/release_builder_spec.rb
-
spec/lib/gitlab/json_cache_spec.rb
-
spec/lib/gitlab/language_detection_spec.rb
-
spec/lib/gitlab/project_search_results_spec.rb
...
...
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-hook-data.yml
0 → 100644
View file @
fa36d3bc
---
title
:
Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/hook_data
merge_request
:
58262
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/lib/gitlab/hook_data/issue_builder_spec.rb
View file @
fa36d3bc
...
...
@@ -5,6 +5,7 @@ require 'spec_helper'
RSpec
.
describe
Gitlab
::
HookData
::
IssueBuilder
do
let_it_be
(
:label
)
{
create
(
:label
)
}
let_it_be
(
:issue
)
{
create
(
:labeled_issue
,
labels:
[
label
],
project:
label
.
project
)
}
let
(
:builder
)
{
described_class
.
new
(
issue
)
}
describe
'#build'
do
...
...
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
View file @
fa36d3bc
...
...
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec
.
describe
Gitlab
::
HookData
::
MergeRequestBuilder
do
let_it_be
(
:merge_request
)
{
create
(
:merge_request
)
}
let
(
:builder
)
{
described_class
.
new
(
merge_request
)
}
describe
'#build'
do
...
...
spec/lib/gitlab/hook_data/release_builder_spec.rb
View file @
fa36d3bc
...
...
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec
.
describe
Gitlab
::
HookData
::
ReleaseBuilder
do
let_it_be
(
:project
)
{
create
(
:project
,
:public
,
:repository
)
}
let
(
:release
)
{
create
(
:release
,
project:
project
)
}
let
(
:builder
)
{
described_class
.
new
(
release
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment