Use 'case/when/end'

fa64da65 · Shinya Maeda · e3fd8caf · fa64da65
Commit fa64da65 authored Mar 07, 2017 by Shinya Maeda
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 7 deletions

app/finders/pipelines_finder.rb app/finders/pipelines_finder.rb +5 -7

No files found.
--- a/app/finders/pipelines_finder.rb
+++ b/app/finders/pipelines_finder.rb
@@ -88,13 +88,11 @@ class PipelinesFinder
  end
  def by_yaml_errors(items)
-    flg = Gitlab::Utils.to_boolean(params[:yaml_errors])
+    case Gitlab::Utils.to_boolean(params[:yaml_errors])
-    if !flg.nil?
+    when true
-      if flg
+      items.where("yaml_errors IS NOT NULL")
-        items.where("yaml_errors IS NOT NULL")
+    when false
-      else
+      items.where("yaml_errors IS NULL")
-        items.where("yaml_errors IS NULL")
-      end
    else
      items
    end