Merge branch '329360-remove-executehooksworker-worker' into 'master'

Remove ExecuteHooksWorker

See merge request gitlab-org/gitlab!63626

app/workers/all_queues.yml

@@ -637,15 +637,6 @@
   :idempotent:
   :tags:
   - :exclude_from_kubernetes
-- :name: deployment:deployments_execute_hooks
-  :worker_name: Deployments::ExecuteHooksWorker
-  :feature_category: :continuous_delivery
-  :has_external_dependencies:
-  :urgency: :low
-  :resource_boundary: :cpu
-  :weight: 3
-  :idempotent:
-  :tags: []
 - :name: deployment:deployments_finished
   :worker_name: Deployments::FinishedWorker
   :feature_category: :continuous_delivery

app/workers/deployments/execute_hooks_worker.rb

-# frozen_string_literal: true
-
-module Deployments
-  # TODO: remove in https://gitlab.com/gitlab-org/gitlab/-/issues/329360
-  class ExecuteHooksWorker # rubocop:disable Scalability/IdempotentWorker
-    include ApplicationWorker
-
-    sidekiq_options retry: 3
-
-    queue_namespace :deployment
-    feature_category :continuous_delivery
-    worker_resource_boundary :cpu
-
-    def perform(deployment_id)
-      if (deploy = Deployment.find_by_id(deployment_id))
-        deploy.execute_hooks(Time.current)
-      end
-    end
-  end
-end

spec/workers/deployments/execute_hooks_worker_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Deployments::ExecuteHooksWorker do
-  let(:worker) { described_class.new }
-
-  describe '#perform' do
-    before do
-      allow(ProjectServiceWorker).to receive(:perform_async)
-    end
-
-    it 'executes project services for deployment_hooks' do
-      deployment = create(:deployment, :running)
-      project = deployment.project
-      service = create(:service, type: 'SlackService', project: project, deployment_events: true, active: true)
-
-      expect(ProjectServiceWorker).to receive(:perform_async).with(service.id, an_instance_of(Hash))
-
-      worker.perform(deployment.id)
-    end
-
-    it 'does not execute an inactive service' do
-      deployment = create(:deployment, :running)
-      project = deployment.project
-      create(:service, type: 'SlackService', project: project, deployment_events: true, active: false)
-
-      expect(ProjectServiceWorker).not_to receive(:perform_async)
-
-      worker.perform(deployment.id)
-    end
-
-    it 'does not execute if a deployment does not exist' do
-      expect(ProjectServiceWorker).not_to receive(:perform_async)
-
-      worker.perform(non_existing_record_id)
-    end
-
-    it 'execute webhooks' do
-      deployment = create(:deployment, :running)
-      project = deployment.project
-      web_hook = create(:project_hook, deployment_events: true, project: project)
-
-      expect_next_instance_of(WebHookService, web_hook, an_instance_of(Hash), "deployment_hooks") do |service|
-        expect(service).to receive(:async_execute)
-      end
-
-      worker.perform(deployment.id)
-    end
-  end
-end

spec/workers/every_sidekiq_worker_spec.rb

@@ -195,7 +195,6 @@ RSpec.describe 'Every Sidekiq worker' do
         'DeleteUserWorker' => 3,
         'Deployments::AutoRollbackWorker' => 3,
         'Deployments::DropOlderDeploymentsWorker' => 3,
-        'Deployments::ExecuteHooksWorker' => 3,
         'Deployments::FinishedWorker' => 3,
         'Deployments::ForwardDeploymentWorker' => 3,
         'Deployments::LinkMergeRequestWorker' => 3,