Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
facd519c
Commit
facd519c
authored
Sep 24, 2020
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes start a new discussion not working with unified diff lines
Closes
https://gitlab.com/gitlab-org/gitlab/-/issues/255278
parent
be019e51
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
app/assets/javascripts/diffs/components/parallel_diff_comment_row.vue
...avascripts/diffs/components/parallel_diff_comment_row.vue
+4
-4
No files found.
app/assets/javascripts/diffs/components/parallel_diff_comment_row.vue
View file @
facd519c
...
...
@@ -113,8 +113,8 @@ export default {
},
methods
:
{
...
mapActions
(
'
diffs
'
,
[
'
showCommentForm
'
]),
showNewDiscussionForm
()
{
this
.
showCommentForm
({
lineCode
:
this
.
line
.
line_code
,
fileHash
:
this
.
diffFileHash
});
showNewDiscussionForm
(
lineCode
)
{
this
.
showCommentForm
({
lineCode
,
fileHash
:
this
.
diffFileHash
});
},
},
};
...
...
@@ -134,7 +134,7 @@ export default {
v-if=
"!hasDraftLeft"
:has-form=
"showLeftSideCommentForm"
:render-reply-placeholder=
"shouldRenderReplyPlaceholderOnLeft"
@
showNewDiscussionForm=
"showNewDiscussionForm"
@
showNewDiscussionForm=
"showNewDiscussionForm
(line.left.line_code)
"
>
<template
#form
>
<diff-line-note-form
...
...
@@ -159,7 +159,7 @@ export default {
v-if=
"!hasDraftRight"
:has-form=
"showRightSideCommentForm"
:render-reply-placeholder=
"shouldRenderReplyPlaceholderOnRight"
@
showNewDiscussionForm=
"showNewDiscussionForm"
@
showNewDiscussionForm=
"showNewDiscussionForm
(line.right.line_code)
"
>
<
template
#form
>
<diff-line-note-form
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment