Commit fc5ebc3c authored by Stan Hu's avatar Stan Hu Committed by Yorick Peterse

Fix uninitialized constant with GitLab Pages deploy

pages:deploy step was failing with the following error:

```
unitialized constant SafeZip::Extract::Zip
```

Since license_finder already pulls in rubyzip, we can make it
a required gem. We also use the scope operator to make the reference to
Zip::File explicit.
parent c0dbf23c
...@@ -57,7 +57,7 @@ gem 'u2f', '~> 0.2.1' ...@@ -57,7 +57,7 @@ gem 'u2f', '~> 0.2.1'
# GitLab Pages # GitLab Pages
gem 'validates_hostname', '~> 1.0.6' gem 'validates_hostname', '~> 1.0.6'
gem 'rubyzip', '~> 1.2.2', require: false gem 'rubyzip', '~> 1.2.2'
# Browser detection # Browser detection
gem 'browser', '~> 2.5' gem 'browser', '~> 2.5'
......
---
title: Fix uninitialized constant with GitLab Pages
merge_request:
author:
type: fixed
...@@ -29,7 +29,7 @@ module SafeZip ...@@ -29,7 +29,7 @@ module SafeZip
private private
def extract_with_ruby_zip(params) def extract_with_ruby_zip(params)
Zip::File.open(archive_path) do |zip_archive| ::Zip::File.open(archive_path) do |zip_archive|
# Extract all files in the following order: # Extract all files in the following order:
# 1. Directories first, # 1. Directories first,
# 2. Files next, # 2. Files next,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment