Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fd187a53
Commit
fd187a53
authored
Apr 22, 2021
by
Huzaifa Iftikhar
Committed by
Mark Chao
Apr 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EmptyLineAfterFinalLetItBe offenses for merge request module
parent
7b72698a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
2 deletions
+7
-2
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-2
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-merge-request-module.yml
...6-fix-empty-line-after-let-it-be-merge-request-module.yml
+5
-0
spec/features/merge_request/user_creates_merge_request_spec.rb
...features/merge_request/user_creates_merge_request_spec.rb
+1
-0
spec/features/merge_request/user_posts_notes_spec.rb
spec/features/merge_request/user_posts_notes_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
fd187a53
...
...
@@ -941,8 +941,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
spec/features/groups_spec.rb
-
spec/features/issues/user_sees_breadcrumb_links_spec.rb
-
spec/features/markdown/metrics_spec.rb
-
spec/features/merge_request/user_creates_merge_request_spec.rb
-
spec/features/merge_request/user_posts_notes_spec.rb
-
spec/features/operations_sidebar_link_spec.rb
-
spec/features/participants_autocomplete_spec.rb
-
spec/features/projects/badges/pipeline_badge_spec.rb
...
...
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-merge-request-module.yml
0 → 100644
View file @
fd187a53
---
title
:
Fix EmptyLineAfterFinalLetItBe offenses for merge request module
merge_request
:
58185
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/features/merge_request/user_creates_merge_request_spec.rb
View file @
fd187a53
...
...
@@ -7,6 +7,7 @@ RSpec.describe "User creates a merge request", :js do
let_it_be
(
:project
)
{
create
(
:project
,
:repository
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:title
)
{
"Some feature"
}
before
do
...
...
spec/features/merge_request/user_posts_notes_spec.rb
View file @
fd187a53
...
...
@@ -6,6 +6,7 @@ RSpec.describe 'Merge request > User posts notes', :js do
include
NoteInteractionHelpers
let_it_be
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:user
)
{
project
.
creator
}
let
(
:merge_request
)
do
create
(
:merge_request
,
source_project:
project
,
target_project:
project
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment