1. 08 Dec, 2019 2 commits
    • Jan Provaznik's avatar
      Merge branch 'sh-fix-order-dependent-spec' into 'master' · 0123a8ea
      Jan Provaznik authored
      Fix order-dependent spec in Gitaly cleanup spec
      
      Closes #38535
      
      See merge request gitlab-org/gitlab!21370
      0123a8ea
    • Stan Hu's avatar
      Fix order-dependent spec in Gitaly cleanup spec · e271deec
      Stan Hu authored
      Stubs for Gitaly calls are memoized by storage and service names in the
      `@stubs` class variable. Normally this doesn't cause a problem, but an
      example in `spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`
      expected that a new stub would always be instantiated. Since
      `spec/services/projects/cleanup_service_spec.rb` preceded
      `spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`, the stub had
      already been instantiated, causing the test to fail.
      
      To fix this problem, we just clear out the Gitaly stubs for
      `spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb`.
      
      Closes https://gitlab.com/gitlab-org/gitlab/issues/38535
      e271deec
  2. 07 Dec, 2019 7 commits
  3. 06 Dec, 2019 31 commits