1. 04 Jul, 2017 3 commits
    • Timothy Andrew's avatar
      0754a442
    • Timothy Andrew's avatar
      Add integration tests around OAuth login. · d2859f86
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
      d2859f86
    • Timothy Andrew's avatar
      Implement "remember me" for OAuth-based login. · c3c642bf
      Timothy Andrew authored
      - Pass a `remember_me` query parameter along with the initial OAuth request, and
        pick this parameter up during the omniauth callback from
        request.env['omniauth.params']`
      
      - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to
        `params`, which the 2FA process will pick up.
      
      - For non-2FA-based login, simply call the `remember_me` devise method to set
        the session cookie.
      c3c642bf
  2. 03 Jul, 2017 32 commits
  3. 02 Jul, 2017 4 commits
  4. 01 Jul, 2017 1 commit