- 22 Feb, 2022 1 commit
-
-
Stan Hu authored
Previously when a merge request was created, the `after_create` Rails callback would fire the `FetchSourceBranch` Gitaly RPC. However, this call is made inside a database transaction, which may have an idle in transaction timeout. On GitLab.com, this timeout is set to 30 seconds, so any `FetchSourceBranch` calls taking longer than 30 seconds causes the database connection to be terminated quietly. When Rails attempts to make another database write (e.g. writing the metrics), the query fails with a 500 error after the RPC completed, usually because a subsequent query ran into an error. Instead of failing after the idle in transaction, this commit will cause the query to be killed if the total Web request time expires (60 seconds or so). While this isn't ideal, this is better than the alternative because we should never hold open a database transaction for a long Gitaly call. Gitaly team has a few optimizations for `FetchSourceBranch` in the works, but allowing this RPC to run for up to 60 seconds during a Web request is better than the status quo. Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/336657 Changelog: fixed
-
- 18 Feb, 2022 39 commits
-
-
Paul Slaughter authored
[bug-fix] Copy button in Enable Review App modal is broken See merge request gitlab-org/gitlab!80561
-
Ahmet Eren BOYACI authored
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/80561 Changelog: fixed
-
Suzanne Selhorn authored
Add a section to get started with the newly provisioned cluster See merge request gitlab-org/gitlab!81011
-
Viktor Nagy (GitLab) authored
-
Nick Gaskill authored
Reverting deprecation MR for Self-Monitoring See merge request gitlab-org/gitlab!81059
-
Dan Davison authored
Update Group Policy Pending Membership Specs See merge request gitlab-org/gitlab!81045
-
Jason Goodman authored
Test each role rather than just developer
-
Dan Davison authored
Update Project Policy Pending Membership Specs See merge request gitlab-org/gitlab!81047
-
Jason Goodman authored
Test each role rather than only developer
-
Nick Gaskill authored
Reverting Self-Monitoring Documentation Deprecation Announcement See merge request gitlab-org/gitlab!81058
-
Alana Bellucci authored
This reverts merge request !76891
-
Christopher Lefelhocz authored
Add Limits to Definition of Done See merge request gitlab-org/gitlab!80243
-
Alana Bellucci authored
This reverts merge request !80535
-
Suzanne Selhorn authored
Update What Warrants a Changelog Entry for Documentation Changes See merge request gitlab-org/gitlab!81050
-
Jason Goodman authored
-
Mayra Cabrera authored
Clean up spec labels See merge request gitlab-org/gitlab!80981
-
Jose Ivan Vargas authored
Add metrics to training link on vulnerability details page See merge request gitlab-org/gitlab!80643
-
Alper Akgun authored
Utilize Nokogiri streaming capabilities for CoverageReportWorker See merge request gitlab-org/gitlab!79866
-
Nikola Milojevic authored
- Parse xml per class node instead of whole file
-
Suzanne Selhorn authored
Add diagram for membership types See merge request gitlab-org/gitlab!80120
-
Evan Read authored
-
Suzanne Selhorn authored
Document ARM architecture support in agentk See merge request gitlab-org/gitlab!80987
-
Suzanne Selhorn authored
Add GitOps secrets management page See merge request gitlab-org/gitlab!80947
-
Viktor Nagy (GitLab) authored
-
Andrew Fontaine authored
Rewrite search input styles for webkit See merge request gitlab-org/gitlab!80479
-
Dheeraj Joshi authored
This reverts commit 97b92b23dc64f40d2380bebf7fc512fc8498e81b.
-
release-tools approver bot authored
Update Gitaly version See merge request gitlab-org/gitlab!81044
-
Kerri Miller authored
Adds crossProjectPipelineAvailable to NamespaceType See merge request gitlab-org/gitlab!80381
-
Kerri Miller authored
Don't return 500 error in Commits API when repository is missing See merge request gitlab-org/gitlab!80410
-
Kerri Miller authored
Add initialize with readme checkbox in repo creation for registration flow See merge request gitlab-org/gitlab!79770
-
lauraMon authored
Changelog: added
-
GitLab Release Tools Bot authored
-
Stan Hu authored
Revert https related changes to webpack config See merge request gitlab-org/gitlab!81031
-
Suzanne Selhorn authored
CTRT update for value stream analytics See merge request gitlab-org/gitlab!80491
-
Fiona Neill authored
-
Nick Gaskill authored
Link to supported schema versions See merge request gitlab-org/gitlab!80692
-
Thiago Figueiró authored
-
Samantha Ming authored
This adds tracking to capture the click of the security training link on the vulnerablity details page.
-
Stan Hu authored
Respect webpack live reload setting See merge request gitlab-org/gitlab!81030
-