- 20 May, 2021 40 commits
-
-
Alex Kalderimis authored
Due to a bug in our sidekiq middleware, post-update actions were not being applied after changing assignees. This is fixed by changing the format of the arguments to the background worker. An unused worker is deleted, and we opt-in to the use of specialized workers in the API, meaning we can delete some duplicated code. Details of the fix: This is vital to getting correct deduplication behavior in our sidekiq middleware. The current logic is: - CLIENT creates hash from worker queue name and arguments (calling `#to_s`) - a job matching that hash is already running (in the working queue), it is not enqueued by the client. - otherwise, the job is serialized and sent to the server - SERVER pops the job and deserializes it - the server runs the job - The server calculates the deduplication hash, and deletes it, allowing similar jobs to be enqueued again. This protocol relies on serialization being completely isomorphic. i.e. `load . serialize === id`. If not, then the two hashes will not match, and the deduplication block will remain up, and not be taken down by the server. The workaround in our case is to use a round-trippable hashmap (i.e. string keys rather than symbols), since: ``` JSON.load({ 'x' => true}.to_json) == { 'x' => true } ``` but ``` JSON.load({ x: => true}.to_json) /= { x: => true } ``` See: https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1090 Changelog: fixed
-
Achilleas Pipinellis authored
docs: Update Redis with the minimum version 5.0 See merge request gitlab-org/gitlab!62159
-
Mikołaj Wawrzyniak authored
Hide billing plans with hide card attribute See merge request gitlab-org/gitlab!61990
-
Vitaly Slobodin authored
-
Sean McGivern authored
Remove Unicorn support: delete Unicorn Sampler See merge request gitlab-org/gitlab!62090
-
David Fernandez authored
Move gosec to alphabetical order See merge request gitlab-org/gitlab!61948
-
David Fernandez authored
Fix blob preview error See merge request gitlab-org/gitlab!62128
-
Phil Hughes authored
Refactor LabelToken to use BaseToken See merge request gitlab-org/gitlab!61992
-
Mikołaj Wawrzyniak authored
Add description to 2 analytics metrics See merge request gitlab-org/gitlab!62046
-
Dan Jensen authored
-
Sean McGivern authored
Set current project/group in WebHookWorker context [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!62130
-
Nick Thomas authored
Merge branch '331461-follow-template-development-guidelines-on-container-scanning-template' into 'master' Follow template development guidelines for Container Scanning See merge request gitlab-org/gitlab!62157
-
Aleksei Lipniagov authored
With removing Unicorn support in 14.0, UnicornSampler is no longer needed. Raindrops was only used with Unicorn, so it could be removed too. Update the docs related to the change. Changelog: removed
-
Kati Paizee authored
List requirements to see FE snowplow events See merge request gitlab-org/gitlab!62077
-
Nicolas Dular authored
-
Alex Kalderimis authored
Keyset paginator for AR::Relation See merge request gitlab-org/gitlab!60412
-
Adam Hegyi authored
Initial implementation of the ActiveRecord::Relation keyset paginator.
-
Sashi Kumar Kumaresan authored
-
Vitali Tatarintev authored
Redirect some deprecated repository routes See merge request gitlab-org/gitlab!34867
-
Alessio Caiazza authored
Disable ci_drop_cyclical_triggered_pipelines feature flag See merge request gitlab-org/gitlab!62181
-
Vitali Tatarintev authored
Return 404 from branches API when repository does not exist See merge request gitlab-org/gitlab!62089
-
charlie ablett authored
Fix design management references in the the data dictionary See merge request gitlab-org/gitlab!62052
-
Nick Thomas authored
Fix argument help for Workhorse apiCiLongPollingDuration command See merge request gitlab-org/gitlab!62150
-
Marius Bobin authored
-
Sanad Liaquat authored
Fix group_saml_enforced_sso_new_account_spec:35 end-to-end test See merge request gitlab-org/gitlab!61975
-
Matthias Käppler authored
Remove Unicorn support: update individual specs See merge request gitlab-org/gitlab!62107
-
Heinrich Lee Yu authored
Add descriptions for BlobActionEnum See merge request gitlab-org/gitlab!61817
-
alinamihaila authored
-
Albert Salim authored
Use the existence of ee/ directory in job rules See merge request gitlab-org/gitlab!61758
-
alinamihaila authored
-
Alina Mihaila authored
-
Christen Dybenko authored
-
Heinrich Lee Yu authored
Ignore labels remove_on_close column See merge request gitlab-org/gitlab!62119
-
Jonathan Schafer authored
-
charlie ablett authored
Move issue tracker integrations to the `Integrations::` namespace See merge request gitlab-org/gitlab!61744
-
Alper Akgun authored
Merge branch '327736-add-extra-arguments-to-metric-yaml-defintion-for-filtering-data-in-instrumentation-class' into 'master' Add options arguments to Redis HLL Metric YAML definition for filtering data in instrumentation class See merge request gitlab-org/gitlab!61685
-
Alina Mihaila authored
Add options arguments to Redis HLL Metric YAML definition for filtering data in instrumentation class
-
Stan Hu authored
Check for credit card when playing manual jobs See merge request gitlab-org/gitlab!62124
-
Fabio Pitino authored
Prevent a user from running previously created manual jobs. Changelog: fixed
-
Luke Duncalfe authored
Extract gitaly RPC backup strategy See merge request gitlab-org/gitlab!61544
-