- 09 Mar, 2021 23 commits
-
-
Chad Woolley authored
Switch to new modern captcha modal which uses Pajamas modal and handles all CAPTCHA rendering on the client. This introduces new, more decoupled approach of using axios interceptors to handle captcha modal hooks. The backend now returns a 409 CONFLICT with a spam_log_id and captcha_site_key. On the frontend side we, the aforementioned interceptor detects this error, opens a modal asking the user to solve the captcha. If the captcha is solved successfully, it re-issues the request, attaching the captchaResponse. If it isn't solved, it will throw an `UnresolvedCaptchaError` instead. The application can choose to gracefully handle this error, or treat it as any other axios request error. For now the interceptors only support PATCH, POST and PUT. Future iterations might want to switch to using HTTP headers instead, which would mean we could extend the approach to the other HTTP methods as well. In this commit we are converting the issue update captcha to use this methodology. Before using an axios interceptor we needed to track the state of the captcha in the application and the logic looked something like this: ```mermaid sequenceDiagram participant U as User participant V as Vue Application participant G as GitLab API U->>V: Save issue V->>G: Request G--xV: Response with Error and Captcha Data V->>U: Please solve Captcha U->>V: Captcha Solution V->>G: Resend Request with solved Captcha Data G-->>V: Response with Success ``` Now we are doing this: ```mermaid sequenceDiagram participant U as User participant V as Vue Application participant A as Axios Interceptor participant G as GitLab API U->>V: Save issue V->>G: Request G--xA: Response with Error and Captcha Data A->>U: Please solve Captcha U->>A: Captcha Solution A->>G: Resend Request with solved Captcha Data G-->>A: Response with Success A-->>V: Response with Success ``` This way we have decoupled the Captcha handling from our Vue Application. For all the Vue Application knows, it is just a request that takes a bit longer than usual. This has the benefit that adding captcha support to new Vue endpoints is as easy as: ```js registerCaptchaModalInterceptor(axios); ``` Co-authored-by: Lukas Eipert <leipert@gitlab.com>
-
Russell Dickenson authored
docs: Fix secret detection variable reference See merge request gitlab-org/gitlab!55768
-
Kushal Pandya authored
Merge branch '273294-fy21q4-foundations-kr2-audit-and-update-buttons-on-groupscontroller-show' into 'master' Update buttons on GroupsController#show See merge request gitlab-org/gitlab!55819
-
Jeremy Elder authored
-
Kushal Pandya authored
Upgrade tiptap and prosemirror dependencies See merge request gitlab-org/gitlab!56002
-
Kushal Pandya authored
Geo Node Status 2.0 - Node Header See merge request gitlab-org/gitlab!55399
-
Zack Cuddy authored
This change adds the header info with placeholder for its details for the Geo nodes. This header is also collapsable and will collapse the full node details in a future MR.
-
Evan Read authored
Gitaly docs cleanup See merge request gitlab-org/gitlab!55297
-
Mark Lapierre authored
Extract fork spec into legacy and new fork form See merge request gitlab-org/gitlab!55461
-
Samantha Ming authored
Part of issue: https://gitlab.com/gitlab-org/gitlab/-/issues/15013
-
Mark Chao authored
Remove usage_data_i_source_code_code_intelligence flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!51765
-
James Fargher authored
Update usage dictionary generator to clean up whitespace See merge request gitlab-org/gitlab!55956
-
Marcel Amirault authored
Update avoids lines that end in whitespace
-
Marcel Amirault authored
Removed extra spaces between CI and CD See merge request gitlab-org/gitlab!56048
-
Kerri Miller authored
Add Packages::Debian::FindOrCreatePackageService [RUN ALL RSPEC] See merge request gitlab-org/gitlab!51891
-
Mark Chao authored
Jira Issue Detail page: Jira users with username See merge request gitlab-org/gitlab!55778
-
Russell Dickenson authored
Shortcut page cleanup See merge request gitlab-org/gitlab!56024
-
Dan Davison authored
Dequarantine snippet tests See merge request gitlab-org/gitlab!55962
-
Mathieu Parent authored
-
Mathieu Parent authored
-
Mathieu Parent authored
-
Evan Read authored
Changed navigate to go See merge request gitlab-org/gitlab!56047
-
Evan Read authored
Update test cases screenshots See merge request gitlab-org/gitlab!56010
-
- 08 Mar, 2021 17 commits
-
-
Steve Abrams authored
Update cluster agent tokens with null names See merge request gitlab-org/gitlab!55673
-
Emily Ring authored
Renamed migrations since master now has a conflicting migration Added missing db/schema_migrations/20210303165302
-
Dylan Griffith authored
Merge branch '301055-update-metrics-definitions-for-product-intelligence-group-elasticsearch-enabled' into 'master' Update Metric defintion for elasticsearch_enabled See merge request gitlab-org/gitlab!56007
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!56011
-
Mayra Cabrera authored
Adds CVE ID Request button to issue sidebar - RUN AS-IF-FOSS [RUN ALL RSPEC] See merge request gitlab-org/gitlab!41203
-
James Johnson authored
Also: * Adds a setting to enable the button in the project general settings * Adds a new column to the `project_settings` database table * Adds new vue components: * project_feature_labeled_toggle.vue * cve_id_request_sidebar.vue
-
Suzanne Selhorn authored
-
Suzanne Selhorn authored
-
James Fargher authored
Reducing variable instantiations in blame processing See merge request gitlab-org/gitlab!55973
-
Luke Duncalfe authored
Track group coverage visits in vue instead See merge request gitlab-org/gitlab!55687
-
Miranda Fluharty authored
Count unique users in the same way as other group::testing metrics So we can use the unique user counts in aggregated metrics
-
James Fargher authored
Add mutation to accept merge requests See merge request gitlab-org/gitlab!54758
-
David O'Regan authored
Project Settings Repository Deploy Keys Header Expand/Collapse 7/8 See merge request gitlab-org/gitlab!55234
-
Daniel Schömer authored
Project Settings General Headers (h4 elements) expand/collapse on mouse-click / tap, like using the Expand/Collapse button. Other h4 headers in other Project Settings pages do not expande/collapse on mouse-click / tap, but only using the Expand/Collapse button. This may seem inconsistent to the user. The h4 headers of Project Settings General get the expand/collapse behavior through classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only. This MR adds classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only to the h4 headers in Project Settings Repository Deploy keys. This enables the expand/collapse behavior on mouse-click / tap for the h4 headers.
-
Stan Hu authored
Enable codequality_backend_comparison by default See merge request gitlab-org/gitlab!54241
-
Jose Ivan Vargas authored
Move from btn-success to btn-confirm in shared/deploy_keys directory See merge request gitlab-org/gitlab!55299
-
Maxime Orefice authored
This commit enables our new feature flag by default which switch our codequality report comparison from the frontend to the backend.
-