1. 29 Mar, 2019 11 commits
    • Mark Florian's avatar
      Replace deprecated component · 2c0dd6cc
      Mark Florian authored
      GitLab adopted @gitlab/ui^3.0.0 during the lifetime of this branch. The
      breaking change introduced the GlSearchBoxByType and GlSearchBoxByClick
      components, and removed the GlSearchBox.
      2c0dd6cc
    • Mark Florian's avatar
      Remove unused translatable strings · 25d5d33f
      Mark Florian authored
      25d5d33f
    • Mark Florian's avatar
      Avoid scrollbar in more maintainable way · 676bd228
      Mark Florian authored
      What this (and the previous) approach aims to achieve is *not* to show
      a scrollbar in the severity filter dropdown. It's a fixed list of
      severities, and inside a `dropdown-content`, the dropdown items are only
      *just* tall enough to be taller than the max-height of
      `dropdown-content`, making it render with a scrollbar, looking terrible.
      
      The report type filter dropdown is also a fixed list of only four items,
      so also doesn't need an internal scrollbar.
      
      The projects filter dropdown, however, is not a fixed list, and requires
      the internal scrollbar provided by `dropdown-content`.
      676bd228
    • Mark Florian's avatar
      Use more explicit/less confusing function name · 8575ee72
      Mark Florian authored
      It takes options objects (id/name key/value pairs), not `Map`s.
      8575ee72
    • Mark Florian's avatar
      Verify exact strings in tests · d9bb4cd1
      Mark Florian authored
      This approach gives us two things:
      
      1. Exact strings are verified, rather than more loosely checking for
         a substring
      2. Should the string change in future, these tests no longer have to
         change. The purpose of them is to verify that some constant is
         returned, but they don't care what that constant actually contains.
      d9bb4cd1
    • Mark Florian's avatar
      Use more natural expectation · b9e5d0c9
      Mark Florian authored
      Previously the `|| null` was ensuring that the return type of the helper
      function was `HTMLElement | null`, rather than `HTMLElement | null
      | undefined`, which allowed the tests to check against just `null`.
      Instead of documenting that oddness, this just changes the tests to
      expect an HTMLElement (or not), removing the need to avoid `undefined`.
      b9e5d0c9
    • Mark Florian's avatar
      Make base GSD filters translatable · d4f206d4
      Mark Florian authored
      d4f206d4
    • Mark Florian's avatar
      Remove unused component · 5fdb0060
      Mark Florian authored
      5fdb0060
    • Mark Florian's avatar
      f1153dd6
    • Mark Florian's avatar
      Add changelog entry · c59b4504
      Mark Florian authored
      c59b4504
    • Mark Florian's avatar
      Improve dropdowns in Group Security Dashboard · 0a149963
      Mark Florian authored
      Each dropdown now:
      
      - stays open as items in it are checked/unchecked
      - has a header and close button
      - shows a search box when there are many items in it
      - use a more specific name for the "All" filter; e.g., "All severities"
      0a149963
  2. 28 Mar, 2019 29 commits