1. 15 Oct, 2018 33 commits
  2. 14 Oct, 2018 6 commits
    • Thong Kuah's avatar
      85316bbb
    • Evan Read's avatar
      Merge branch 'docs-bad-links-1' into 'master' · 93fc4a6d
      Evan Read authored
      Docs: Fixing some bad links
      
      See merge request gitlab-org/gitlab-ce!22287
      93fc4a6d
    • Marcel Amirault's avatar
      Docs: Fixing some bad links · 5849a0ce
      Marcel Amirault authored
      5849a0ce
    • Thong Kuah's avatar
      Remove un-used inheritance from service · 504cbb27
      Thong Kuah authored
      Remove the inheritance from ::BaseService which is causing us to inherit
      the initializer that has project as the first arg, as we will not have
      access to project with forthcoming group clusters.
      
      Also call install service from create service - 1 less thing to re-use
      
      Extract TestRequest code into a spec helper. Given that we need
      different behaviour for Rails 5.0 (and again in Rails 5.1!), it's handy
      to have that branching behaviour in one place
      504cbb27
    • Thong Kuah's avatar
      Move non-controller code into dedicated service · cc1ccbf8
      Thong Kuah authored
      This should help with code re-use when we create applications for group
      level cluster next.
      
      Change `find_or_initialize_by` to explicitly find or build the right
      association based on the application name. The benefit here is that we
      use the associations on @cluster rather than querying from the other
      side of the association.
      cc1ccbf8
    • Thong Kuah's avatar
      Pass in project as kwarg for CreateService · 19e1024b
      Thong Kuah authored
      This enables us to have other options in the future such as passing in
      `group:`.
      
      Also, remove project arg from UpdateService, as un-used.
      
      This will help group cluster controller to re-use this services.
      19e1024b
  3. 13 Oct, 2018 1 commit