The method is named wrap_authorized_projects_with_cte but we're actually
passing an arbitrary collection / query here.

Retrieving repositories from personal namespace on GitLab.com results in
an error. This is a regression introduced in f755a5ff.

The intent was to return all projects for instance admins but we don't
need to include public projects for regular users.

GitLab admin are not seeing merge requests in Jira Development
Panel Integration when they are not a member of the group /
project

The Jira integration requires a Premium license, we can enable this for
the entire spec. This spot a false-positive causing a failure spec that
we have to fix.

This fix the current failing spec and also cover the other endpoint.
This change fixes the following endpoints:
- https://gitlab.com/api/v3/repos/:namespace/:project/branches
- https://gitlab.com/api/v3/repos/:namespace/:project/commits/:sha

There were three sources of N+1 queries here: the license check, the
path and namespace information, and the root namespace.

The license check was the worst. We were checking the license
information on each project individually. This meant we couldn't
paginate in SQL, but did so in Ruby, so it was not only an N+1, it was
loading too many records.

To fix this, we use the fact that this API endpoint can only return
projects in a particular namespace. License checks end up at one of two
places: for most instances, it's the instance's license itself. For
GitLab.com, where individual namespaces have their own plan, it's the
root namespace (subgroups can't have plans; they inherit their plan from
the root).

This means that we only ever need a single check. If it passes, every
project returned has the feature available. If it fails, we return a
404, like the other endpoints here. That way we can paginate in SQL, as
we should.

The path and namespace information N+1 was simple to fix: just preload
that information.

The final N+1 was on the root namespace, which we return as the `owner`
field for compatibility with GitHub. Again, this was always the same for
all items in the response, but we can't preload it easily because
different projects will be at different levels of the hierarchy.
Instead, we just calculate the root namespace once, and pass that as an
option to the entity. The entity uses that value if it's given, and
falls back to calculating it if it's not (in case this entity is used
elsewhere without that option).

Add spec for note filtering on epics

This moves the `requirements` options to the top-level
route so that all routes inherit the option

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

Even though `rubocop --auto-gen-config` was run, it looks like some
files still needed to be corrected.

Also reduced a bit of duplication and
created a user.json schema file which
is referenced by pull_request.json and
pull_requests.json references
pull_request.json now.
Moved content of "url" field to "html_url"

According to https://developer.github.com/v3/users the "url" field
should contain an api url - not the html url.

Additionally Jira Pull Requests are now showing an avatar of the PR
author.

Add changelog entry

Add missing mr number

Add specs

Expose url of user in url and html_url

I decided against returning an empty string for url (which is,
according to api documentation, supposed to return an api endpoint
instead of a user profile page) but make it return the profile page
as before so the changes won't break any existing code.

Remove extra blank line

Use `Project.public_or_visible_to_user` instead of
`current_user.authorized_projects`

Remove obsolete comment

Enables frozen string in the following:

* ee/lib/*.rb
* ee/lib/api/**/*.rb
* ee/lib/audit/**/*.rb
* ee/lib/banzai/**/*.rb
* ee/lib/ee/**/*.rb
* ee/lib/elasticsearch/**/*.rb
* ee/lib/generators/**/*.rb

Also enables frozen string in some vestigial
files of the ee/app directory.

Partially addresses gitlab-org/gitlab-ce/#47424.

This whitelists various EE specific offenses of the various CodeReuse
cops.

Jira needs to be given a bare domain (no path) for its configuration,
otherwise it confuses itself and does not use the proper API endpoints.
This was the reason why we always say requests like `/-/jira/pulls`
before (it uses whatever path is given always)

Signed-off-by: Rémy Coutable <remy@rymai.me>