- 12 Sep, 2019 40 commits
-
-
Thomas Randolph authored
Cases tested: - Separator - Divider - Header
-
Thomas Randolph authored
Basic Intent: Allow all branch names without accidentally creating layout or backstage DOM. e.g. a branch named `separator` should never create a separator `li` element. Ideally, there should never be a string that could cause this kind of conflict. Implementation: All of `GitLabDropdown.renderItem` is extracted to a standalone module. To render a divider or separator, consumers must now pass in an object like `{ "type": "divider" }` or `{ "type": "separator" }` Notable choices: - All of the functions have a cyclomatic complexity of 3 or less - See: https://en.wikipedia.org/wiki/Cyclomatic_complexity - Note the "Correlation to number of defects" section - While software complexity may not have a directly causal relationship with defects, less complex software is generally easier to reason about, and **may** reduce defects. I personally try to maintain complexity of no higher than 3. - Everything other than the branch names fix matches past behavior exactly - Including: - Unused variables - Class list order
-
Lin Jen-Shin authored
Enable mock setup to make onboarding development easier See merge request gitlab-org/gitlab-ee!15492
-
Doug Stull authored
- it used to be complicated to setup your local environment in order to work on the onboarding tour. Full of temporary changes that would need backed out - now we can work on it merely by enabling the Feature flag :user_onboarding
-
Rémy Coutable authored
Add pod status for review-app release in debug See merge request gitlab-org/gitlab-ee!16522
-
Rémy Coutable authored
Remove EE specific checks See merge request gitlab-org/gitlab-ee!16513
-
Alessio Caiazza authored
-
Michael Kozono authored
Remove orphaned project registries Closes #13158 See merge request gitlab-org/gitlab-ee!15021
-
James Lopez authored
[Backend] Step 3 API for trials See merge request gitlab-org/gitlab-ee!16339
-
Aishwarya Subramanian authored
We need to create Leads when customers are requesting a trial for GL.com. In order to do it we're going to use a service that will call a custom endpoint on the subscription portal.
-
Kyle Wiebers authored
-
Nick Thomas authored
Ensure right order of processing multipart requests See merge request gitlab-org/gitlab-ee!16461
-
Filipa Lacerda authored
[EE] Fix broken master by ensuring the EE version of ListIssue is imported if available Closes #31797 and #31798 See merge request gitlab-org/gitlab-ee!16506
-
GitLab Bot authored
-
Marcia Ramos authored
Add warning about LE wildcard certificate for pages See merge request gitlab-org/gitlab-ce!32643
-
Vladimir Shushlin authored
Apply suggestion to doc/user/project/pages/custom_domains_ssl_tls_certification/lets_encrypt_integration.md
-
GitLab Bot authored
-
Andreas Brandl authored
Create self-monitoring project in background migration See merge request gitlab-org/gitlab-ce!32819
-
Reuben Pereira authored
- A regular migration caused problems such as https://gitlab.com/charts/gitlab/issues/1565.
-
Nick Thomas authored
Fix encoding error in MR diffs Closes #61841 See merge request gitlab-org/gitlab-ce!32862
-
Stan Hu authored
Fix code docs for RuboCop's helper methods See merge request gitlab-org/gitlab-ce!32937
-
Peter Leitzen authored
`(const nil :Foo)` vs `(const nil? :Foo)`
-
Walmyr Lima e Silva Filho authored
Add end-to-end test for issue board focus mode Closes gitlab-org/quality/testcases#182 See merge request gitlab-org/gitlab-ee!16300
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
GitLab Bot authored
-
Andreas Brandl authored
Fix member expiration not always working Closes #67286 See merge request gitlab-org/gitlab-ce!32951
-
GitLab Bot authored
-
Peter Leitzen authored
Setup counter for Productivity Analytics See merge request gitlab-org/gitlab-ce!32915
-
Adam Hegyi authored
This change sets up a usage counter for productivity analytics feature.
-
Peter Leitzen authored
Track usage data for analytics features See merge request gitlab-org/gitlab-ee!16431
-
Adam Hegyi authored
- Track page view counts for Group Cycle Analytics. - Setup counter for Productivity Analytics and track page view counts. - Add changelog entry
-
GitLab Bot authored
-
Filipa Lacerda authored
Productivity Analytics: Add error handling for reporting on groups which have no plan Closes #13571 See merge request gitlab-org/gitlab-ee!15291
-
Martin Wortschack authored
- Display an error illustration in case the API responds with 403 for a given group_id - Update PO file - Update sepcs - Add changelog entry
-
Filipa Lacerda authored
Removed padding from project filter field See merge request gitlab-org/gitlab-ce!32706
-
Denys Mishunov authored
Resolves a regression caused by https://bit.ly/2k1GozA
-
Filipa Lacerda authored
Fix merge_request_spec test See merge request gitlab-org/gitlab-ce!32867
-
GitLab Bot authored
-
Rémy Coutable authored
Merge branch '50847-automatically-created-mr-uses-wrong-source-branch-when-branching-from-tag' into 'master' Resolve "Automatically created MR uses wrong source branch (when branching from Tag)" Closes #50847 See merge request gitlab-org/gitlab-ce!32392
-
🙈 jacopo beschi 🙉 authored
Creating a MR from an issue using a tag as ref correctly creates the source branch starting from the tag.
-