1. 27 Jan, 2017 1 commit
    • Stan Hu's avatar
      Fix GitLab Pages not refreshing upon new content · 4ef145f4
      Stan Hu authored
      Due to autoloading and Ruby scoping, the .update file was never being
      updated due to this error:
      
      ```
      NoMethodError: undefined method `pages' for Projects::Settings:Module
              from /opt/gitlab/embedded/service/gitlab-rails/app/services/projects/update_pages_configuration_service.rb:50:in `pages_update_file'
              from /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:157:in `pages_update_file'
              from (irb):6
              from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:110:in `start'
              from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:9:in `start'
              from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:68:in `console'
              from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
              from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands.rb:17:in `<top (required)>'
              from bin/rails:9:in `require'
      ```
      
      This error was caught and discarded quietly. This fix exercises this code and fixes the scope problem.
      
      Closes gitlab-com/infrastructure#1058
      4ef145f4
  2. 26 Jan, 2017 28 commits
  3. 25 Jan, 2017 11 commits